Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blob/trace): cover blob service with traces #3113

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

vgonkivs
Copy link
Member

Cover Blob service with Otel traces. Partly fixes #3112

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b57ad60) 51.84% compared to head (cb30c02) 51.95%.

Files Patch % Lines
blob/service.go 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
+ Coverage   51.84%   51.95%   +0.10%     
==========================================
  Files         178      178              
  Lines       11239    11262      +23     
==========================================
+ Hits         5827     5851      +24     
- Misses       4911     4912       +1     
+ Partials      501      499       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ramin
ramin previously approved these changes Jan 18, 2024
Copy link
Contributor

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

distractedm1nd
distractedm1nd previously approved these changes Jan 22, 2024
blob/service.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from distractedm1nd and ramin via fe0aa2b January 22, 2024 18:22
blob/service.go Outdated Show resolved Hide resolved
@Wondertan Wondertan merged commit f235d10 into celestiaorg:main Jan 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics(blob): Add trace paths through blob module to trace Read paths
5 participants