Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(rpc): implementing go-da interface #3146

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Jan 29, 2024

Integrates go-da directly to eliminate the need for celestia-da.

@distractedm1nd distractedm1nd added area:rpc kind:feat Attached to feature PRs labels Jan 29, 2024
@distractedm1nd distractedm1nd self-assigned this Jan 29, 2024
@distractedm1nd distractedm1nd marked this pull request as ready for review February 1, 2024 10:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d7c7697) 51.88% compared to head (f3e5096) 52.06%.

Files Patch % Lines
blob/blob.go 57.14% 6 Missing and 3 partials ⚠️
nodebuilder/rpc/constructors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
+ Coverage   51.88%   52.06%   +0.18%     
==========================================
  Files         178      178              
  Lines       11262    11284      +22     
==========================================
+ Hits         5843     5875      +32     
+ Misses       4918     4908      -10     
  Partials      501      501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramin
Copy link
Contributor

ramin commented Feb 1, 2024

kind of a lot going on here and i realize it's mostly just copied over but....main question from me before getting into weeds is: "is da and the go-da the right naming for this bit of work/module in the node project?". I don't think i have an answer and maybe @Wondertan has more of an opinion on naming.

Only other thing that jumps out at me and could use a comment before deeper review is the Marshall func on blob...i vaguely sense we maybe had a bug around this not that long ago....

@distractedm1nd
Copy link
Collaborator Author

@Wondertan and I discussed naming before I started this PR because I had the same concerns. It is very confusing to have both "da" and "das" package. But we came to the conclusion it's the best name for now - but if you have any suggestions I am very open to it, because I hate "da" as well

As per the blob proof marshalling: Yes, there was a bug that nmt.Proof was not json serializable. We added json serialization in the nmt package to solve this. Is this what you mean?

@distractedm1nd
Copy link
Collaborator Author

Reminder that the point of this PR is simply to move celestia-da code into node, so that we can debug the existing problems more easily - fixes will be expected, but it needs to get released as soon as possible

@Wondertan
Copy link
Member

I am OK with calling this da if we change das to sampler or smlr. Changing, this shouldn't be part of this PR, but we should at least have an issue to clean this ambiguity after this is merged

Wondertan
Wondertan previously approved these changes Feb 1, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ramin
ramin previously approved these changes Feb 1, 2024
Copy link
Contributor

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test fails, can we fix or remove then otherwise 👍

@distractedm1nd
Copy link
Collaborator Author

Ahhh it's flaky

@distractedm1nd distractedm1nd dismissed stale reviews from ramin and Wondertan via 8de5c5c February 1, 2024 15:52
@distractedm1nd distractedm1nd enabled auto-merge (squash) February 1, 2024 15:54
@ramin ramin self-requested a review February 1, 2024 15:55
@distractedm1nd distractedm1nd merged commit 625cdf3 into celestiaorg:main Feb 1, 2024
21 of 22 checks passed
@renaynay renaynay changed the title feat(rpc): implementing go-da interface feat!(rpc): implementing go-da interface Feb 12, 2024
@renaynay renaynay added the kind:break! Attached to breaking PRs label Feb 12, 2024
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Feb 15, 2024
Integrates go-da directly to eliminate the need for
[celestia-da](https://github.com/rollkit/celestia-da).
renaynay added a commit that referenced this pull request Mar 5, 2024
…#3204)

Reverts a change introduced in
#3146 that
unintentionally broke `blob.Proof` serialisation.

Resolves #3173
renaynay added a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
…celestiaorg#3204)

Reverts a change introduced in
celestiaorg#3146 that
unintentionally broke `blob.Proof` serialisation.

Resolves celestiaorg#3173
renaynay added a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
…celestiaorg#3204)

Reverts a change introduced in
celestiaorg#3146 that
unintentionally broke `blob.Proof` serialisation.

Resolves celestiaorg#3173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:break! Attached to breaking PRs kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants