fix: improve rpc.skip-auth #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
ramin
as code owners
ramin
reviewed
Feb 1, 2024
distractedm1nd
force-pushed
the
skipauth
branch
from
eb4e640
to
b24a706
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
+ Coverage 51.68% 51.76% +0.07%
==========================================
Files 178 178
Lines 11284 11284
==========================================
+ Hits 5832 5841 +9
+ Misses 4951 4938 -13
- Partials 501 505 +4 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Feb 1, 2024
ramin
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current skip-auth implementation, there was an issue: Authentication could be skipped, but it still required the
Authenticationheader to be set (it just wouldn't check it).This PR improves the devex by removing this requirement. I missed it the first time because I tested by using the CLI, which always sets the header regardless of what you pass. This came up while implementing eigerco/lumina#210, since the wasm client cannot set headers.
I also think the solution is cleaner than the original.