Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder/share): Make module construction more digestable #3170

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Feb 8, 2024

I tried to clean up the share module construction a bit so that it's easier to parse. Hopefully this is more helpful than the mess that was there prior.

Also please carefully review this PR!! I tried my best to make sure that all components are added where they are supposed to be but it's possible I may have missed something (although all related units are passing).

@codecov-commenter
Copy link

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (01585ba) 0.00% compared to head (9d3e286) 51.81%.
Report is 1 commits behind head on main.

Files Patch % Lines
nodebuilder/share/module.go 0.00% 98 Missing ⚠️
nodebuilder/share/constructors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3170       +/-   ##
=========================================
+ Coverage      0   51.81%   +51.81%     
=========================================
  Files         0      178      +178     
  Lines         0    11312    +11312     
=========================================
+ Hits          0     5861     +5861     
- Misses        0     4949     +4949     
- Partials      0      502      +502     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner! I guess this was coming out work from networking part of pruning. I feel like it may also help(or the opposite) for the shwap integration. Will carefully review once I am back

ramin
ramin previously approved these changes Feb 12, 2024
Wondertan
Wondertan previously approved these changes Feb 12, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it carefully and couldn't find anything suspicious. We had to run the node with these changes to be very sure.

There are still a bunch of things to do to make module construction really clean, but I believe this a good step towards that

nodebuilder/share/module.go Show resolved Hide resolved
nodebuilder/share/module.go Show resolved Hide resolved
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked carefully into it and wasn't able to spot any issues. It looks much cleaner now. Thank you for this!

nodebuilder/share/module.go Show resolved Hide resolved
nodebuilder/share/module.go Outdated Show resolved Hide resolved
nodebuilder/share/module.go Outdated Show resolved Hide resolved
@renaynay renaynay dismissed stale reviews from Wondertan and ramin via e87976f February 19, 2024 16:33
@renaynay renaynay merged commit 1809680 into celestiaorg:main Feb 21, 2024
23 checks passed
@renaynay renaynay deleted the cleanussy-share-module branch February 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants