-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nodebuilder/share): Make module construction more digestable #3170
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3170 +/- ##
=========================================
+ Coverage 0 51.81% +51.81%
=========================================
Files 0 178 +178
Lines 0 11312 +11312
=========================================
+ Hits 0 5861 +5861
- Misses 0 4949 +4949
- Partials 0 502 +502 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner! I guess this was coming out work from networking part of pruning. I feel like it may also help(or the opposite) for the shwap integration. Will carefully review once I am back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it carefully and couldn't find anything suspicious. We had to run the node with these changes to be very sure.
There are still a bunch of things to do to make module construction really clean, but I believe this a good step towards that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked carefully into it and wasn't able to spot any issues. It looks much cleaner now. Thank you for this!
I tried to clean up the share module construction a bit so that it's easier to parse. Hopefully this is more helpful than the mess that was there prior.
Also please carefully review this PR!! I tried my best to make sure that all components are added where they are supposed to be but it's possible I may have missed something (although all related units are passing).