Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to Go 1.22 #3228

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Mar 1, 2024

Description

Upgrade to Go 1.22 and celestia-app v1.7.0.

Motivation

I originally opened this PR to bump to celestia-app v1.7.0 but I had to bundle in a bump to Go version 1.22 because go mod tidy auto updated the go directive:

$ go1.21.1 mod tidy
go: github.com/celestiaorg/celestia-app@v1.7.0-rc0 requires go >= 1.22.0; switching to go1.22.0

This behavior was unexpected because I thought applications could use libraries with different Go versions. 🤔

@github-actions github-actions bot added the external Issues created by non node team members label Mar 1, 2024
@rootulp rootulp added the kind:deps Pull requests that update a dependency file label Mar 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (c1ab9c5) to head (d1c8b40).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
- Coverage   52.08%   44.94%   -7.15%     
==========================================
  Files         183      265      +82     
  Lines       11594    14635    +3041     
==========================================
+ Hits         6039     6578     +539     
- Misses       5043     7300    +2257     
- Partials      512      757     +245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rootulp
Copy link
Contributor Author

rootulp commented Mar 1, 2024

@rootulp rootulp changed the title chore(deps): upgrade to app v1.7.0-rc0 chore(deps): upgrade to Go 1.22 Mar 1, 2024
@rootulp rootulp self-assigned this Mar 1, 2024
@rootulp rootulp marked this pull request as ready for review March 1, 2024 18:58
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! And pyroscope upgrade 🚀

@rootulp rootulp merged commit 7ea607b into celestiaorg:main Mar 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants