refactor: chunk -> share #3240
Merged
refactor: chunk -> share #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
adlerjohn,
liamsi,
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3240 +/- ##
==========================================
- Coverage 52.08% 44.81% -7.28%
==========================================
Files 183 265 +82
Lines 11594 14620 +3026
==========================================
+ Hits 6039 6552 +513
- Misses 5043 7315 +2272
- Partials 512 753 +241 ☔ View full report in Codecov by Sentry. |
ramin
approved these changes
Mar 6, 2024
walldiss
approved these changes
Mar 6, 2024
|
This PR needs a docs codeowner approval because it touches docs/adr. cc: @adlerjohn @liamsi 
Ref: celestia-node/.github/CODEOWNERS Line 12 in 32bc7a9 |
liamsi
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename instances of
chunktoshare.Motivation
The rsmt2d repo uses chunks and shares interchangeably and we increase readability if one term was used consistently. A few people have expressed favor for share over chunk because of it's broader usage in celestia-node and celestia-app.
See celestiaorg/rsmt2d#215
Note: There aren't occurrences of shard or buffer that need renaming in this repo. Shard is used frequently but it seems applicable to https://github.com/filecoin-project/dagstore/blob/master/docs/design.md#shards and not meant to refer to a share.