refactor(nodebuilder): use external flock library #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Wondertan
force-pushed
the
hlib/fslock-new
branch
from
e01390e to
b5e3e5a
Compare
ramin
previously approved these changes
Mar 13, 2024
vgonkivs
previously approved these changes
Mar 13, 2024
vgonkivs
reviewed
Mar 13, 2024
vgonkivs
approved these changes
Mar 13, 2024
walldiss
approved these changes
Mar 13, 2024
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
This PR is prompted by celestiaorg#3246. While looking through the code and understanding how `IsLocked` worked there, I realized that our fslock lib was missing a feature. Instead of asking @mastergaurang94 to fix it, I decided to completely migrate over to a more [comprehensive locking solution](https://github.com/gofrs/flock), which additionally: * avoids the need custom code to maintain(NIHS) * solves the problem of locking being annoying after an ungraceful shutdown * gives us Windows and other niche OS support * as well as works around niche FS edge-cases
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
This PR is prompted by celestiaorg#3246. While looking through the code and understanding how `IsLocked` worked there, I realized that our fslock lib was missing a feature. Instead of asking @mastergaurang94 to fix it, I decided to completely migrate over to a more [comprehensive locking solution](https://github.com/gofrs/flock), which additionally: * avoids the need custom code to maintain(NIHS) * solves the problem of locking being annoying after an ungraceful shutdown * gives us Windows and other niche OS support * as well as works around niche FS edge-cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prompted by #3246. While looking through the code and understanding how
IsLockedworked there, I realized that our fslock lib was missing a feature. Instead of asking @mastergaurang94 to fix it, I decided to completely migrate over to a more comprehensive locking solution, which additionally: