refactor(nodebuilder): stick to lock semantics, not file #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
walldiss
approved these changes
Mar 13, 2024
vgonkivs
approved these changes
Mar 13, 2024
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
…#3255) Review discussion that did't get to the PR because of automerge
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
…#3255) Review discussion that did't get to the PR because of automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review discussion that did't get to the PR because of automerge