feat: add workdir to dockerfile #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
smuu
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
+ Coverage 44.83% 44.91% +0.08%
==========================================
Files 265 263 -2
Lines 14620 14634 +14
==========================================
+ Hits 6555 6573 +18
+ Misses 7313 7311 -2
+ Partials 752 750 -2 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Mar 18, 2024
ramin
approved these changes
Mar 19, 2024
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
This should be a non-breaking change. This only changes the work directory when the container is started. This means that if you want to execute a command in a running container, it will be automatically in that directory instead of '/'. This improves maintaining and debugging our environments.
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
This should be a non-breaking change. This only changes the work directory when the container is started. This means that if you want to execute a command in a running container, it will be automatically in that directory instead of '/'. This improves maintaining and debugging our environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a non-breaking change.
This only changes the work directory when the container is started. This means that if you want to execute a command in a running container, it will be automatically in that directory instead of '/'. This improves maintaining and debugging our environments.