Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Bridge node short-circuits storing a historical EDS if pruning is enabled #3283

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

renaynay
Copy link
Member

This PR implements short-circuiting storing EDSes in the case that they are outside the sampling window in the case of a syncing bridge node if --experimental-pruning is enabled.

Overrides #3261

@renaynay renaynay added area:storage area:core_and_app Relationship with Core node and Celestia-App kind:feat Attached to feature PRs labels Mar 28, 2024
@renaynay renaynay self-assigned this Mar 28, 2024
core/exchange.go Outdated Show resolved Hide resolved
@renaynay renaynay force-pushed the bridge-node-short-circuit branch from fecaa29 to 95c16ea Compare April 2, 2024 14:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 45.03%. Comparing base (2469e7a) to head (6fc0b60).
Report is 21 commits behind head on main.

Files Patch % Lines
pruner/window.go 0.00% 4 Missing ⚠️
nodebuilder/pruner/module.go 81.25% 3 Missing ⚠️
core/exchange.go 81.81% 2 Missing ⚠️
core/listener.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
+ Coverage   44.83%   45.03%   +0.19%     
==========================================
  Files         265      272       +7     
  Lines       14620    14932     +312     
==========================================
+ Hits         6555     6724     +169     
- Misses       7313     7449     +136     
- Partials      752      759       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay marked this pull request as ready for review April 2, 2024 15:17
Wondertan
Wondertan previously approved these changes Apr 4, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the proofs have to be excluded when outside of the window, as you state

core/listener_test.go Show resolved Hide resolved
core/exchange.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes Apr 9, 2024
walldiss
walldiss previously approved these changes Apr 9, 2024
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

core/exchange.go Outdated Show resolved Hide resolved
core/exchange.go Outdated Show resolved Hide resolved
vgonkivs
vgonkivs previously approved these changes Apr 10, 2024
@renaynay renaynay dismissed stale reviews from walldiss and Wondertan via c77029b April 10, 2024 12:01
@renaynay renaynay requested review from walldiss and Wondertan April 10, 2024 12:07
@renaynay renaynay enabled auto-merge (squash) April 10, 2024 12:16
@renaynay renaynay merged commit 26d411a into celestiaorg:main Apr 10, 2024
26 checks passed
@renaynay renaynay deleted the bridge-node-short-circuit branch April 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core_and_app Relationship with Core node and Celestia-App area:storage kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants