-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Bridge node short-circuits storing a historical EDS if pruning is enabled #3283
feat(core): Bridge node short-circuits storing a historical EDS if pruning is enabled #3283
Conversation
…cing if pruning enabled
…r test do not store historic
fecaa29
to
95c16ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
+ Coverage 44.83% 45.03% +0.19%
==========================================
Files 265 272 +7
Lines 14620 14932 +312
==========================================
+ Hits 6555 6724 +169
- Misses 7313 7449 +136
- Partials 752 759 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the proofs have to be excluded when outside of the window, as you state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR implements short-circuiting storing EDSes in the case that they are outside the sampling window in the case of a syncing bridge node if
--experimental-pruning
is enabled.Overrides #3261