-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(state): Remove need for core RPC conn and rely only on gRPC for state reads #3359
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
- Coverage 44.83% 44.56% -0.28%
==========================================
Files 265 272 +7
Lines 14620 15244 +624
==========================================
+ Hits 6555 6793 +238
- Misses 7313 7666 +353
- Partials 752 785 +33 ☔ View full report in Codecov by Sentry. |
Is it in scope of this Pr to ensure TLS encryption works for gRPC? And for bridge nodes TLS for RPC to core? If not I assume this will be tackled shortly after? |
It's good to have if for privacy reasons so that no MITM can see the addresses and balances you request. Worth having an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
There was an over 10 months old issue and it was closed... Rene opened a new one #3377 |
🤔 I guess Ramin misunderstood the relation of that issue because one does not replace the other one. |
"Make secured connection possible" |
Resolves #3357
Blocked on patch release from app including celestiaorg/celestia-app#3424
Corresponding docs PR celestiaorg/docs#1558