-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share): Shwap Bitwap composition #3421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
reviewed
May 24, 2024
cristaloleg
reviewed
May 27, 2024
Wondertan
force-pushed
the
shwap-bitswap-composition
branch
from
May 27, 2024 12:44
7f218e2
to
0a63a38
Compare
Wondertan
force-pushed
the
shwap-bitswap-composition
branch
from
May 29, 2024 15:05
d6bcc2e
to
51feefd
Compare
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
ramin
as code owners
May 30, 2024 21:13
walldiss
reviewed
Jun 3, 2024
cristaloleg
reviewed
Jun 3, 2024
cristaloleg
reviewed
Jun 3, 2024
cristaloleg
reviewed
Jun 3, 2024
cristaloleg
reviewed
Jun 3, 2024
Wondertan
commented
Jun 5, 2024
walldiss
force-pushed
the
shwap
branch
4 times, most recently
from
June 10, 2024 11:58
c4550bf
to
60e757e
Compare
Wondertan
force-pushed
the
shwap-bitswap-composition
branch
from
June 12, 2024 17:37
aabc51e
to
0e6a558
Compare
Wondertan
force-pushed
the
shwap-bitswap-composition
branch
from
June 20, 2024 18:10
78c169e
to
3e8ac7b
Compare
cristaloleg
reviewed
Jun 21, 2024
walldiss
reviewed
Jun 21, 2024
There are two more things:
|
walldiss
reviewed
Jun 26, 2024
walldiss
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegancy avoiding complexity. Beautiful! 🚀
cristaloleg
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Bitswap composition based on CIP-19 by introducing three Block types for every Shwap container(
Row
,Sample
,RowNamespaceData
). Besides, this PR bringsBlock
interfaces that generalize over those new blocks. This interface enables a slightly convoluted general-purposeFetch
function to get any Block type over Bitswap, abstracting all the complexities. Besides, the current architecture provides a horizontally scalable framework for the new blocks that makes it super easy to add new Shwap containers to our protocol, like for futureRange
andBlob
containers.This is like the
5th6th7th iteration of the composition design and the most straightforward one @walldiss and I could come up with the requirements we had.Respective changes in the spec: celestiaorg/CIPs#159