-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(blob/cmd): remove base64 representation #3553
Conversation
Have you synced w @jcstein about this? |
I've discussed this change with him. But we haven't agreed on removing the flag and I think as we allow now only hexed namespace and commitment it won't have much sense in keeping base64 flag. For the commitment, I think it makes sense to keep all fields consistent. |
962d367
c16e0aa
to
962d367
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 44.83% 45.44% +0.61%
==========================================
Files 265 274 +9
Lines 14620 15446 +826
==========================================
+ Hits 6555 7020 +465
- Misses 7313 7624 +311
- Partials 752 802 +50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no 🚔 today
This PR removes the base64 flag and its related functionality as it was completely unused. Additionally, it changes the return type of the commitment to its hex representation.