refactor(header): Validate should check that the raw header's app version is not greater than latest app version
#3589
+37
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:header
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
renaynay
commented
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3589 +/- ##
==========================================
+ Coverage 44.83% 45.51% +0.68%
==========================================
Files 265 281 +16
Lines 14620 16053 +1433
==========================================
+ Hits 6555 7307 +752
- Misses 7313 7901 +588
- Partials 752 845 +93 ☔ View full report in Codecov by Sentry. |
cmwaters
reviewed
Jul 24, 2024
cmwaters
approved these changes
Jul 24, 2024
vgonkivs
previously approved these changes
Jul 24, 2024
cristaloleg
previously approved these changes
Jul 25, 2024
cristaloleg
previously approved these changes
Jul 29, 2024
cmwaters
approved these changes
Jul 30, 2024
Wondertan
previously approved these changes
Jul 30, 2024
walldiss
previously approved these changes
Jul 30, 2024
rootulp
added a commit
to rootulp/celestia-node
that referenced
this pull request
Aug 1, 2024
Because it will be added in celestiaorg#3589
…n appconsts latest version
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
renaynay
dismissed stale reviews from walldiss, Wondertan, and cristaloleg
via
38ec710
renaynay
force-pushed
the
app-version-check
branch
from
80e20f3
to
38ec710
Compare
cristaloleg
reviewed
Aug 8, 2024
cristaloleg
previously approved these changes
Aug 8, 2024
vgonkivs
previously approved these changes
Aug 8, 2024
rootulp
reviewed
Aug 8, 2024
|
Fraud integration tests failed on CI but pass locally so I'm assuming it's a flake: |
rootulp
requested review from
Wondertan,
vgonkivs,
walldiss,
cristaloleg and
rootulp
Wondertan
approved these changes
Aug 8, 2024
|
wow fully green CI 🟢 |
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
…ersion is not greater than latest app version (celestiaorg#3589) Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for V2, we should change the header validation logic to ensure that we support validation for V2 and below.