feat(shwap): Add bufferisation for writing ods/Q1Q4 files #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
ramin and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3592 +/- ##
========================================
Coverage ? 47.56%
========================================
Files ? 317
Lines ? 18730
Branches ? 0
========================================
Hits ? 8909
Misses ? 8665
Partials ? 1156 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Jul 24, 2024
cristaloleg
reviewed
Jul 25, 2024
Wondertan
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use buffered write of eds shares and axis roots to the disk. According to benchmark it improves write time for writing single block from 79ms -> 19ms (4x).