fix(share): return fixed data size in blockstore #3634
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Wondertan
reviewed
Aug 8, 2024
There was a problem hiding this comment.
One last thing that make me feel uneasy is that we always return the same size even when the real data is less. I spend another hour looking for a solution, but there is no deterministic way.
So we can either return size of a leaf or a node. Leaf size is bigger than node, so we always report more than we actually serve to Bitswap and I worry about implications of lying to bitswap. Also, if we lie, whats better, to over report with leaves or to underreport with nodes.
cristaloleg
force-pushed
the
share/return-fixed-size
branch
from
7626857
to
d99c6b3
Compare
walldiss
approved these changes
Aug 20, 2024
Wondertan
approved these changes
Aug 20, 2024
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit 9fd66a5)
Wondertan
pushed a commit
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit 9fd66a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dummy solution from #3630 . We return a fixed size for any parameters. Always return a max size of 2 possible values: inner or leaf node size.
Fixes #3630