fix(p2p): couple bitswap client and server #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
ramin and
cristaloleg
as code owners
Wondertan
previously approved these changes
Aug 8, 2024
Wondertan
previously approved these changes
Aug 8, 2024
Wondertan
approved these changes
Aug 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
+ Coverage 44.83% 45.62% +0.78%
==========================================
Files 265 281 +16
Lines 14620 16040 +1420
==========================================
+ Hits 6555 7318 +763
- Misses 7313 7887 +574
- Partials 752 835 +83 ☔ View full report in Codecov by Sentry. |
renaynay
approved these changes
Aug 14, 2024
walldiss
added a commit
that referenced
this pull request
Aug 15, 2024
(cherry picked from commit d593e37)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit d593e37)
Wondertan
pushed a commit
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit d593e37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoupled client was not able to notify server on newly available blocks.