chore: remove some TODOs

nodebuilder/da/da.go

@@ -12,7 +12,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 type API struct {
 	Internal struct {
 		MaxBlobSize       func(ctx context.Context) (uint64, error)                                            `perm:"read"`

nodebuilder/das/das.go

@@ -17,7 +17,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 type API struct {
 	Internal struct {
 		SamplingStats func(ctx context.Context) (das.SamplingStats, error) `perm:"read"`

nodebuilder/fraud/fraud.go

@@ -24,7 +24,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 type API struct {
 	Internal struct {
 		Subscribe func(context.Context, fraud.ProofType) (<-chan *Proof, error) `perm:"read"`

nodebuilder/header/header.go

@@ -46,7 +46,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 type API struct {
 	Internal struct {
 		LocalHead func(context.Context) (*header.ExtendedHeader, error) `perm:"read"`

nodebuilder/header/service.go

@@ -81,8 +81,6 @@ func (s *Service) GetByHeight(ctx context.Context, height uint64) (*header.Exten
 			"networkHeight: %d, requestedHeight: %d", head.Height(), height)
 	}
 
-	// TODO(vgonkivs): remove after https://github.com/celestiaorg/go-header/issues/32 is
-	//  implemented and fetch header from HeaderEx if missing locally
 	head, err = s.store.Head(ctx)
 	switch {
 	case err != nil:

nodebuilder/p2p/p2p.go

@@ -199,7 +199,6 @@ func (m *module) PubSubTopics(_ context.Context) ([]string, error) {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 //
 //nolint:dupl
 type API struct {

nodebuilder/share/config.go

@@ -16,7 +16,6 @@ const (
 	defaultBlockstoreCacheSize = 128
 )
 
-// TODO: some params are pointers and other are not, Let's fix this.
 type Config struct {
 	// EDSStoreParams sets eds store configuration parameters
 	EDSStoreParams      *store.Parameters
@@ -28,9 +27,9 @@ type Config struct {
 	// ShrExNDParams sets shrexnd client and server configuration parameters
 	ShrExNDParams *shrexnd.Parameters
 	// PeerManagerParams sets peer-manager configuration parameters
-	PeerManagerParams peers.Parameters
+	PeerManagerParams *peers.Parameters
 
-	LightAvailability light.Parameters `toml:",omitempty"`
+	LightAvailability *light.Parameters `toml:",omitempty"`
 	Discovery         *discovery.Parameters
 }
 

nodebuilder/share/p2p_constructors.go

@@ -64,7 +64,7 @@ func fullDiscoveryAndPeerManager(tp node.Type, cfg *Config) fx.Option {
 			}
 
 			fullManager, err := peers.NewManager(
-				cfg.PeerManagerParams,
+				*cfg.PeerManagerParams,
 				host,
 				connGater,
 				fullNodesTag,
@@ -114,7 +114,7 @@ func archivalDiscoveryAndPeerManager(tp node.Type, cfg *Config) fx.Option {
 			gater *conngater.BasicConnectionGater,
 		) (map[string]*peers.Manager, []*discovery.Discovery, error) {
 			archivalPeerManager, err := peers.NewManager(
-				cfg.PeerManagerParams,
+				*cfg.PeerManagerParams,
 				h,
 				gater,
 				archivalNodesTag,

nodebuilder/share/share.go

@@ -58,7 +58,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 type API struct {
 	Internal struct {
 		SharesAvailable func(context.Context, *header.ExtendedHeader) error `perm:"read"`

nodebuilder/state/state.go

@@ -97,7 +97,6 @@ type Module interface {
 }
 
 // API is a wrapper around Module for the RPC.
-// TODO(@distractedm1nd): These structs need to be autogenerated.
 //
 //nolint:dupl
 type API struct {

share/availability/light/availability.go

@@ -42,7 +42,7 @@ func NewShareAvailability(
 	ds datastore.Batching,
 	opts ...Option,
 ) *ShareAvailability {
-	params := DefaultParameters()
+	params := *DefaultParameters()
 	ds = namespace.Wrap(ds, cacheAvailabilityPrefix)
 	autoDS := autobatch.NewAutoBatching(ds, writeBatchSize)
 

share/availability/light/options.go

@@ -21,8 +21,8 @@ type Option func(*Parameters)
 
 // DefaultParameters returns the default Parameters' configuration values
 // for the light availability implementation
-func DefaultParameters() Parameters {
-	return Parameters{
+func DefaultParameters() *Parameters {
+	return &Parameters{
 		SampleAmount: DefaultSampleAmount,
 	}
 }

share/share.go

@@ -1,7 +1,6 @@
 package share
 
 import (
-	"crypto/sha256"
 	"fmt"
 
 	"github.com/celestiaorg/celestia-app/v2/pkg/appconsts"
@@ -69,7 +68,7 @@ func (s *ShareWithProof) Validate(rootHash []byte, x, y, edsSize int) bool {
 		namespace = GetNamespace(s.Share)
 	}
 	return s.Proof.VerifyInclusion(
-		sha256.New(), // TODO(@Wondertan): This should be defined somewhere globally
+		NewSHA256Hasher(),
 		namespace.ToNMT(),
 		[][]byte{s.Share},
 		rootHash,

share/shwap/p2p/shrex/peers/manager_test.go

@@ -414,7 +414,7 @@ func TestIntegration(t *testing.T) {
 		connGater, err := conngater.NewBasicConnectionGater(dssync.MutexWrap(datastore.NewMapDatastore()))
 		require.NoError(t, err)
 		fnPeerManager, err := NewManager(
-			DefaultParameters(),
+			*DefaultParameters(),
 			nil,
 			connGater,
 			"test",
@@ -477,7 +477,7 @@ func testManager(ctx context.Context, headerSub libhead.Subscriber[*header.Exten
 		return nil, err
 	}
 	manager, err := NewManager(
-		DefaultParameters(),
+		*DefaultParameters(),
 		host,
 		connGater,
 		"test",

share/shwap/p2p/shrex/peers/options.go

@@ -46,8 +46,8 @@ func (p *Parameters) Validate() error {
 }
 
 // DefaultParameters returns the default configuration values for the peer manager parameters
-func DefaultParameters() Parameters {
-	return Parameters{
+func DefaultParameters() *Parameters {
+	return &Parameters{
 		// PoolValidationTimeout's default value is based on the default daser sampling timeout of 1 minute.
 		// If a received datahash has not tried to be sampled within these two minutes, the pool will be
 		// removed.

share/shwap/p2p/shrex/shrex_getter/shrex_test.go

@@ -298,7 +298,7 @@ func testManager(
 		return nil, err
 	}
 	manager, err := peers.NewManager(
-		peers.DefaultParameters(),
+		*peers.DefaultParameters(),
 		host,
 		connGater,
 		"test",