feat(modp2p): close peer connections after successful blocking #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlelouch
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Oct 11, 2024
cristaloleg
changed the title
cristaloleg
previously approved these changes
Oct 11, 2024
renaynay
approved these changes
Oct 11, 2024
renaynay
previously requested changes
Oct 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3838 +/- ##
==========================================
+ Coverage 44.83% 45.17% +0.33%
==========================================
Files 265 314 +49
Lines 14620 21795 +7175
==========================================
+ Hits 6555 9846 +3291
- Misses 7313 10933 +3620
- Partials 752 1016 +264 ☔ View full report in Codecov by Sentry. |
cristaloleg
previously approved these changes
Oct 14, 2024
walldiss
reviewed
Oct 14, 2024
auto-merge was automatically disabled
October 17, 2024 07:29
Head branch was pushed to by a user without write access
cristaloleg
approved these changes
Oct 17, 2024
|
Thanks, LGTM! |
Wondertan
approved these changes
Oct 17, 2024
walldiss
approved these changes
Oct 17, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3791