Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store/cache): unstick cache metrics names #3857

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Oct 17, 2024

Metrics names were not properly delimited. Example:

eds_cacherecent_evicted_counter_total

@walldiss walldiss added area:storage kind:fix Attached to bug-fixing PRs area:metrics Related to measuring/collecting node metrics labels Oct 17, 2024
@walldiss walldiss self-assigned this Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.07%. Comparing base (2469e7a) to head (d2afb0f).
Report is 347 commits behind head on main.

Files with missing lines Patch % Lines
store/cache/metrics.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3857      +/-   ##
==========================================
+ Coverage   44.83%   45.07%   +0.24%     
==========================================
  Files         265      314      +49     
  Lines       14620    21801    +7181     
==========================================
+ Hits         6555     9827    +3272     
- Misses       7313    10951    +3638     
- Partials      752     1023     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss enabled auto-merge (squash) October 19, 2024 23:52
@walldiss walldiss merged commit b4b89fc into celestiaorg:main Oct 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics area:storage kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants