-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eds/cache): Fix prealloc for proof nodes #3860
fix(eds/cache): Fix prealloc for proof nodes #3860
Conversation
edc9059
to
c6a1685
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
==========================================
+ Coverage 44.83% 44.94% +0.10%
==========================================
Files 265 314 +49
Lines 14620 21789 +7169
==========================================
+ Hits 6555 9793 +3238
- Misses 7313 10969 +3656
- Partials 752 1027 +275 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good self catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow
Link #3858 |
Thank you for the fix @walldiss! I highly would encourage adding a test to lock this behavior as it is subtle and even if it changed from a revert (say if something unrelated broke) it would never be caught. |
Previous prealloc calc was incorrect resulting in higher allocation than needed. This is chart of amount of allocation we should have done and actually done:
Fixes #3858