Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nodebuilder): add archival flag #3868

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

walldiss
Copy link
Member

Add warning log in preparation of depreciation of experimental-pruning flag

@walldiss walldiss added the kind:refactor Attached to refactoring PRs label Oct 22, 2024
@walldiss walldiss self-assigned this Oct 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (2469e7a) to head (3db7682).
Report is 358 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/pruner/flags.go 53.57% 11 Missing and 2 partials ⚠️
cmd/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3868      +/-   ##
==========================================
+ Coverage   44.83%   45.22%   +0.39%     
==========================================
  Files         265      311      +46     
  Lines       14620    21884    +7264     
==========================================
+ Hits         6555     9898    +3343     
- Misses       7313    10928    +3615     
- Partials      752     1058     +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cristaloleg
cristaloleg previously approved these changes Oct 22, 2024
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Hlib, let's specify that and also add it to the flag description

@walldiss walldiss changed the title refactor(nodebuilder): warn experimental-pruning flag change refactor(nodebuilder): add archival flag Oct 22, 2024
@walldiss walldiss force-pushed the warn-pruning-flag branch 2 times, most recently from 45f9b61 to 37d7f26 Compare October 22, 2024 15:12
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@walldiss walldiss enabled auto-merge (squash) October 22, 2024 19:03
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @walldiss

@walldiss walldiss merged commit cab778d into celestiaorg:main Oct 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants