-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nodebuilder): add archival flag #3868
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3868 +/- ##
==========================================
+ Coverage 44.83% 45.22% +0.39%
==========================================
Files 265 311 +46
Lines 14620 21884 +7264
==========================================
+ Hits 6555 9898 +3343
- Misses 7313 10928 +3615
- Partials 752 1058 +306 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Hlib, let's specify that and also add it to the flag description
45f9b61
to
37d7f26
Compare
37d7f26
to
7bc420c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uTACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @walldiss
Add warning log in preparation of depreciation of experimental-pruning flag