Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): add gateway deprecation notice #3869

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

walldiss
Copy link
Member

No description provided.

@walldiss walldiss added the kind:refactor Attached to refactoring PRs label Oct 22, 2024
@walldiss walldiss self-assigned this Oct 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (2469e7a) to head (750e7f8).
Report is 359 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/gateway/module.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3869      +/-   ##
==========================================
+ Coverage   44.83%   45.29%   +0.46%     
==========================================
  Files         265      311      +46     
  Lines       14620    21885    +7265     
==========================================
+ Hits         6555     9913    +3358     
- Misses       7313    10915    +3602     
- Partials      752     1057     +305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cristaloleg
cristaloleg previously approved these changes Oct 22, 2024
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Wondertan
Wondertan previously approved these changes Oct 22, 2024
renaynay
renaynay previously approved these changes Oct 22, 2024
@renaynay
Copy link
Member

@walldiss can you also please add the warning to the flag description itself?

@walldiss walldiss dismissed stale reviews from renaynay, Wondertan, and cristaloleg via 449adc4 October 22, 2024 15:22
@Wondertan Wondertan enabled auto-merge (squash) October 22, 2024 16:07
@Wondertan Wondertan disabled auto-merge October 22, 2024 18:53
@Wondertan Wondertan enabled auto-merge (squash) October 22, 2024 18:53
@Wondertan
Copy link
Member

Linter 😭

@Wondertan Wondertan merged commit 01de405 into celestiaorg:main Oct 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants