refactor(share/availability/light | share/availability/full): Availability implementations are aware of sampling window, removed from DASer #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:shares
renaynay
force-pushed
the
split-sampling-windows
branch
from
ccfedc6 to
354e3ab
Compare
renaynay
commented
Dec 2, 2024
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3957 +/- ##
==========================================
+ Coverage 44.83% 45.60% +0.76%
==========================================
Files 265 309 +44
Lines 14620 22013 +7393
==========================================
+ Hits 6555 10039 +3484
- Misses 7313 10904 +3591
- Partials 752 1070 +318 ☔ View full report in Codecov by Sentry. |
|
Merge conflict after Hlib changes. |
…implement in avail impls, fullAvailability takes opts + params
… availability implementations for it
… from archival mode explicitly
…paramters as it doesnt matter if its written on disk, bc we always override it light avail construction which forces it to be defined StorageWindow
…confuse node operators as the value wont actually be configurable
renaynay
force-pushed
the
split-sampling-windows
branch
from
774afa1 to
0724ac9
Compare
cristaloleg
reviewed
Dec 4, 2024
cristaloleg
reviewed
Dec 4, 2024
walldiss
reviewed
Dec 9, 2024
walldiss
approved these changes
Dec 10, 2024
cristaloleg
approved these changes
Dec 10, 2024
vgonkivs
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the concept of
archivalnode explicit, splitting it away from sampling window. Now, both the node's pruning status (archival or not) and the sampling window will have to be provided to availability implementations for them to determine what to sync + what to store. This also applies tocorepackage for BNs as that's their "availability implementation" technically.