Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/adr: Incentivized testnet ADR #634

Merged
merged 5 commits into from
May 6, 2022

Conversation

renaynay
Copy link
Member

No description provided.

@renaynay renaynay self-assigned this Apr 20, 2022
@renaynay renaynay added docs:adr ADR kind:misc Attached to miscellaneous PRs labels Apr 20, 2022
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
Co-authored-by: Nguyen Nhu Viet <braveryandglory@gmail.com>
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the TODOs I think this looks fine.

docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
@renaynay renaynay requested a review from adlerjohn May 5, 2022 14:31
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt nits

docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
docs/adr/adr-007-incentivized-testnet.md Outdated Show resolved Hide resolved
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
@Wondertan Wondertan merged commit 38a6a96 into celestiaorg:main May 6, 2022
@Wondertan Wondertan deleted the incentivised-testnet-adr branch May 6, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs:adr ADR kind:misc Attached to miscellaneous PRs
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants