Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): multiple findings and fixes #807

Merged
merged 7 commits into from
Jun 14, 2022
Merged

fix(all): multiple findings and fixes #807

merged 7 commits into from
Jun 14, 2022

Conversation

Wondertan
Copy link
Member

Multiple independent commits that just fix minor things. Happy to answer any questions about each, if any.

@Wondertan
Copy link
Member Author

711e86a, ba8637f and 042ebe1 are basically fix of artifacts from #730

Copy link
Member Author

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self suggestions to quickly apply the change

service/share/light_availability.go Outdated Show resolved Hide resolved
service/share/light_availability.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #807 (c4421e5) into main (a422ce1) will increase coverage by 0.46%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   53.15%   53.61%   +0.46%     
==========================================
  Files         117      118       +1     
  Lines        6750     6714      -36     
==========================================
+ Hits         3588     3600      +12     
+ Misses       2798     2750      -48     
  Partials      364      364              
Impacted Files Coverage Δ
ipld/retriever.go 90.37% <66.66%> (-0.33%) ⬇️
ipld/nmt_adder.go 68.00% <100.00%> (+4.66%) ⬆️
ipld/plugin/nmt.go 44.55% <100.00%> (+8.66%) ⬆️
node/rpc/component.go 100.00% <100.00%> (ø)
node/services/service.go 83.75% <100.00%> (ø)
service/rpc/middleware.go 100.00% <100.00%> (ø)
service/rpc/server.go 79.06% <100.00%> (-0.94%) ⬇️
service/share/light_availability.go 92.30% <100.00%> (+8.97%) ⬆️
header/core/listener.go 52.83% <0.00%> (-5.67%) ⬇️
das/daser.go 73.68% <0.00%> (-2.64%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31bc64...c4421e5. Read the comment docs.

@renaynay
Copy link
Member

merge conflict @Wondertan

@Wondertan
Copy link
Member Author

Fixed

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@Wondertan Wondertan merged commit df73a26 into main Jun 14, 2022
@Wondertan Wondertan deleted the hlib/all/findings branch June 14, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants