Skip to content

Commit

Permalink
fix links
Browse files Browse the repository at this point in the history
Co-authored-by: Nguyen Nhu Viet <braveryandglory@gmail.com>
  • Loading branch information
evan-forbes and Bidon15 committed Aug 30, 2021
1 parent 45bbca6 commit 21f0b78
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion snapshots/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type restoreDone struct {
//
// 1) In the future, ABCI should support streaming. Consider e.g. InitChain during chain
// upgrades, which currently passes the entire chain state as an in-memory byte slice.
// https://github.com/celestiaorg/celestia-core/issues/5184
// https://github.com/tendermint/tendermint/issues/5184
//
// 2) io.ReadCloser streams automatically propagate IO errors, and can pass arbitrary
// errors via io.Pipe.CloseWithError().
Expand Down
4 changes: 2 additions & 2 deletions store/prefix/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (s Store) Delete(key []byte) {
}

// Implements KVStore
// Check https://github.com/celestiaorg/celestia-core/blob/master/libs/db/prefix_db.go#L106
// Check https://github.com/tendermint/tendermint/blob/master/libs/db/prefix_db.go#L106

This comment has been minimized.

Copy link
@Bidon15

Bidon15 Aug 31, 2021

Author Member

Either for the celestiaorg and tendermint links are throwing 404 error codes 🤔

  • For celestia there is no L106 for the file prefix.db
    Maybe just https://github.com/celestiaorg/celestia-core/blob/master/libs/db/prefixdb_iterator.go can fix the issue

  • For tendermint latest - it seems that they have droppped db directory completely for master

func (s Store) Iterator(start, end []byte) types.Iterator {
newstart := cloneAppend(s.prefix, start)

Expand All @@ -98,7 +98,7 @@ func (s Store) Iterator(start, end []byte) types.Iterator {
}

// ReverseIterator implements KVStore
// Check https://github.com/celestiaorg/celestia-core/blob/master/libs/db/prefix_db.go#L129
// Check https://github.com/tendermint/tendermint/blob/master/libs/db/prefix_db.go#L129

This comment has been minimized.

Copy link
@Bidon15

Bidon15 Aug 31, 2021

Author Member

Same here 😅

func (s Store) ReverseIterator(start, end []byte) types.Iterator {
newstart := cloneAppend(s.prefix, start)

Expand Down
2 changes: 1 addition & 1 deletion store/prefix/store_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func TestPrefixStoreReverseIteratorEdgeCase(t *testing.T) {
iter.Close()
}

// Tests below are ported from https://github.com/celestiaorg/celestia-core/blob/master/libs/db/prefix_db_test.go
// Tests below are ported from https://github.com/tendermint/tendermint/blob/master/libs/db/prefix_db_test.go

This comment has been minimized.

Copy link
@Bidon15

Bidon15 Aug 31, 2021

Author Member

I purpose we either remove this comment as our repo is not containing the file. For tendermint, I haven't file the alternative name for it 😰


func mockStoreWithStuff() types.KVStore {
db := dbm.NewMemDB()
Expand Down
2 changes: 1 addition & 1 deletion third_party/proto/tendermint/abci/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ message Evidence {
];
// Total voting power of the validator set in case the ABCI application does
// not store historical validators.
// https://github.com/celestiaorg/celestia-core/issues/4581
// https://github.com/tendermint/tendermint/issues/4581
int64 total_voting_power = 5;
}

Expand Down

0 comments on commit 21f0b78

Please sign in to comment.