Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preprocess step to decouple Tx and Messages before proposing a block #5

Closed
liamsi opened this issue Jan 4, 2021 · 1 comment
Closed

Use preprocess step to decouple Tx and Messages before proposing a block #5

liamsi opened this issue Jan 4, 2021 · 1 comment
Labels
P:High

Comments

@liamsi
Copy link
Member

liamsi commented Jan 4, 2021

see: celestiaorg/celestia-core#110

Note that the app needs to keep track of the Tx that it processed in order to return "false" on re-check Tx (this comment hopefully explains better why this is necessary): celestiaorg/celestia-core#81 (comment)
@liamsi liamsi mentioned this issue Jan 4, 2021
Closed
@liamsi liamsi added the P:High label Jan 4, 2021
@liamsi liamsi mentioned this issue Jan 21, 2021
Merged
9 tasks
@evan-forbes evan-forbes mentioned this issue Feb 1, 2021
Closed
@liamsi
Copy link
Member Author

liamsi commented Mar 16, 2021

This was actually implemented directly in the app/module: celestiaorg/celestia-app#22

@liamsi liamsi closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P:High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liamsi