Replace tendermint with lazyledger-core #13

evan-forbes · 2021-01-16T00:49:36Z

Description

This PR manually replaces the imports from "github.com/tendermint/tendermint" to "github.com/lazyledger/lazyledger-core" in all go and proto files. It also changes the methods of baseapp.BaseApp to adhere to the new lazyledger-core ABCI interface and a few other minor changes to address compile time errors. It should be noted that the new method is not implemented, or well documented and simply passes all transaction data. This PR is required for before #1 can be finished.

closes: #2

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
this PR only has a template test for the new method added, as the method is not currently implemented.
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

go.mod

update proto to lazyleder-core

baseapp: add todo for PreprocessTxs docs

…tendermint function with std lib go mod tidy

…issue causing panics

finish doc sentence

codecov-io · 2021-01-19T14:43:48Z

Codecov Report

Merging #13 (3235a74) into master (2b01560) will decrease coverage by 0.01%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   61.92%   61.90%   -0.02%     
==========================================
  Files         609      609              
  Lines       35099    35108       +9     
==========================================
+ Hits        21734    21735       +1     
- Misses      11083    11088       +5     
- Partials     2282     2285       +3

Impacted Files	Coverage Δ
baseapp/baseapp.go	`77.29% <ø> (ø)`
baseapp/grpcrouter.go	`86.04% <ø> (ø)`
baseapp/grpcrouter_helpers.go	`31.57% <ø> (ø)`
baseapp/params.go	`100.00% <ø> (ø)`
baseapp/test_helpers.go	`57.14% <ø> (ø)`
client/broadcast.go	`52.05% <ø> (ø)`
client/cmd.go	`59.09% <ø> (ø)`
client/context.go	`59.22% <ø> (ø)`
client/flags/flags.go	`21.27% <ø> (ø)`
client/grpc/tmservice/block.go	`50.00% <ø> (ø)`
... and 118 more

…eplace-tendermint

liamsi · 2021-01-20T22:50:37Z

Is this ready for another review?

evan-forbes · 2021-01-20T23:06:56Z

I was just about to comment, I think so. The first failing check, Lint/golangci-lint, has to do with file permissions that have not been changed, and are present in the cosmos-sdk, but I can change them if anyone thinks it's a good idea. If not, should this check be kept?

The second is failing because some proto rpc methods were "removed". The check is comparing the master branch of the sdk with ours, and the sdk has added some endpoints since we last updated. I can also update to the latest master branch of the sdk if that is desired. If not, should this check be kept? Altered to check our fork?

liamsi · 2021-01-20T23:16:21Z

Thanks! I'll review more thoroughly this week!

Regarding the Error: G306: Expect WriteFile permissions to be 0600 or less (gosec): which files is it complaining about (I don't see it in the CI output).

The second test you mention is the proto_breakage? No need to update to the lastest master yet

Altered to check our fork?

if that's super easy, why not. Otherwise, I'm OK with ignoring that one for this PR (it just checks if the PR has changes to the protobuf files).

evan-forbes · 2021-01-20T23:28:08Z

There are quite a few files afaict. Most are in testing, so I don't think those pose that great a threat. There is this one, but I used the same permissions as the cosmos-sdk version.

There are a bunch of instances where the sdk does not follow this rule, even a 0777, which is confusing.

liamsi

LGTM 💪🏼

liamsi · 2021-01-20T23:47:09Z

baseapp/abci.go

+// for arbitrary processing steps before transaction data is included in the block.
+// todo(evan): update documentation after implemented
+func (app *BaseApp) PreprocessTxs(txs abci.RequestPreprocessTxs) abci.ResponsePreprocessTxs {
+	// TODO(evan): fully implement


You can link to the issue if you want: #5

liamsi · 2021-01-20T23:47:14Z

CHANGELOG.md

@@ -132,6 +132,7 @@ sure you are aware of any relevant breaking changes.
  * (types) [\#5533](https://github.com/cosmos/cosmos-sdk/pull/5533) Refactored `AppModuleBasic` and `AppModuleGenesis`
  to now accept a `codec.JSONMarshaler` for modular serialization of genesis state.
  * (types/rest) [\#5779](https://github.com/cosmos/cosmos-sdk/pull/5779) Drop unused Parse{Int64OrReturnBadRequest,QueryParamBool}() functions.
+  * [\#2](https://github.com/lazyledger/cosmos-sdk/issues/2) Add new abci method `PreprocessTxs` and remove `SetOption`.


Thanks for even taking care of tracking changes 👍🏼 Should we keep our changes in a separate file instead?

liamsi · 2021-01-21T09:02:54Z

go.mod

@@ -26,6 +26,7 @@ require (
 	github.com/grpc-ecosystem/go-grpc-middleware v1.2.2
 	github.com/grpc-ecosystem/grpc-gateway v1.16.0
 	github.com/hashicorp/golang-lru v0.5.4
+	github.com/lazyledger/lazyledger-core v0.0.0-20210115223437-eff282ad2592


One general remark on the module (the cosmos-sdk one): I was wondering if we should rename it from
module github.com/cosmos/cosmos-sdk to module github.com/lazyledger/cosmos-sdk.
I'm almost surprised to see that the replace directive worked in the ll-app without a problem in this case.

Let's update the app when this is merged and see if this works without any further changes.

liamsi · 2021-01-21T09:10:16Z

Regarding gosec. IMO, it complains in this branch but not in the SDK because, here it recognizes the pattern ioutil.WriteFile while it doesn't with tmos.WriteFile:

 -	err = tmos.WriteFile(file, contents, 0644)
 +	err = ioutil.WriteFile(file, contents, 0644)

This can be silenced by sticking to that tmos import instead. Still weird, especially that 0777 place you mentioned above.

manually swith to lazyledger-core

454768a

evan-forbes mentioned this pull request Jan 16, 2021

Switch to lazyledger-core instead of tendermint #2

Closed

liamsi reviewed Jan 18, 2021

View reviewed changes

go.mod Show resolved Hide resolved

evan-forbes mentioned this pull request Jan 18, 2021

Liveness Test fails in Github Actions #14

Closed

evan-forbes added 11 commits January 19, 2021 08:05

manually replace tendermint with lazyledger-core in all proto files

bc946bf

update proto to lazyleder-core

baseapp: delete old tendermint abci method

614b9b4

baseapp: partially implement new ABCI method

1a4a727

baseapp: add todo for PreprocessTxs docs

bubble new error, switch to field instead of method, and replace old …

d639642

…tendermint function with std lib go mod tidy

server: fixed bug that stops config from being unmarshalled by viper

74d88c9

fix tag to allow for proper unmarshalling

99ae19e

regenerate proto bindings

750a424

use the latest version of lazyledger-core to fix the grpc versioning …

e93f9ea

…issue causing panics

add template test for the new abci method

9657e69

finish doc sentence

update changelog

4423dbb

running gofmt -s

3235a74

evan-forbes force-pushed the evan/replace-tendermint branch from 8cabc60 to 3235a74 Compare January 19, 2021 14:34

Merge branch 'master' of github.com:lazyledger/cosmos-sdk into evan/r…

73d1760

…eplace-tendermint

liamsi approved these changes Jan 21, 2021

View reviewed changes

evan-forbes merged commit 3addd7f into master Jan 21, 2021

evan-forbes deleted the evan/replace-tendermint branch January 21, 2021 15:27

evan-forbes mentioned this pull request Feb 25, 2021

update to the latest version of lazyledger-core #19

Closed

evan-forbes mentioned this pull request Aug 30, 2021

use celestiaorg instead of lazyledger #28

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace tendermint with lazyledger-core #13

Replace tendermint with lazyledger-core #13

evan-forbes commented Jan 16, 2021 •

edited

Loading

codecov-io commented Jan 19, 2021

liamsi commented Jan 20, 2021

evan-forbes commented Jan 20, 2021 •

edited

Loading

liamsi commented Jan 20, 2021 •

edited

Loading

evan-forbes commented Jan 20, 2021 •

edited

Loading

liamsi left a comment

liamsi Jan 20, 2021

liamsi Jan 20, 2021

liamsi Jan 21, 2021

liamsi commented Jan 21, 2021 •

edited

Loading

Replace tendermint with lazyledger-core #13

Replace tendermint with lazyledger-core #13

Conversation

evan-forbes commented Jan 16, 2021 • edited Loading

Description

codecov-io commented Jan 19, 2021

Codecov Report

liamsi commented Jan 20, 2021

evan-forbes commented Jan 20, 2021 • edited Loading

liamsi commented Jan 20, 2021 • edited Loading

evan-forbes commented Jan 20, 2021 • edited Loading

liamsi left a comment

Choose a reason for hiding this comment

liamsi Jan 20, 2021

Choose a reason for hiding this comment

liamsi Jan 20, 2021

Choose a reason for hiding this comment

liamsi Jan 21, 2021

Choose a reason for hiding this comment

liamsi commented Jan 21, 2021 • edited Loading

evan-forbes commented Jan 16, 2021 •

edited

Loading

evan-forbes commented Jan 20, 2021 •

edited

Loading

liamsi commented Jan 20, 2021 •

edited

Loading

evan-forbes commented Jan 20, 2021 •

edited

Loading

liamsi commented Jan 21, 2021 •

edited

Loading