feat: adds orchestrator address to validator in staking module #112
Conversation
rach-id
changed the title
|
Adds to: celestiaorg/celestia-app#283 |
…ress_to_validator_init
|
@evan-forbes Can you take a look please ? |
There was a problem hiding this comment.
this makes sense I think, and I'm find with approving even with failed CI as long as its not the default branch.
We also need to start thinking about the scenario where we don't start from genesis, and instead we hardfork/upgrade to include the QGB, and what state migrations would be required.
|
Some thoughts around starting the QGB. Messaging compatibilityIn the scenario where we don't start from genesis, I guess it is still alright. Around starting the QGB on an existing chainFor an already running chain, to start the QGB, we only need the current valset to have orchestrator/Ethereum addresses. There can be two ways to do it. Hard fork the chainAdd a new parameter specifying the height we want to start the QGB on. When we start the QGB, any validator who doesn't have an Ethereum/orchestrator address setup, they get kicked from the valset (we could add some validator set sanitization mechanism). Social coordinationAsk the validators to update their software and set up the Orchestrator/Ethereum address gently. Then, we start the QGB once all the current valset validators are ready (we give them a week or so, to be ready). After starting the QGBPost the starting ceremony, we could have a new check on the staking module, verifying that no validator can move to the current validator set if it doesn't have an orchestrator/Ethereum address set. Questions
|
|
@evan-forbes Does it make sense to create some issue where we discuss this ? |
let's discuss synchronously, and then create issues there's a specific way to migrate state during a hardfork/upgrade using the sdk, and we will want to use that |
|
Sounds good 👍 I will merge this PR now. |
|
@evan-forbes I don't have permissions to merge :( Can you please? |
rach-id
changed the title
rach-id
changed the title
| ) | ||
|
|
||
| // EthAddress Regular EthAddress | ||
| type EthAddress struct { |
There was a problem hiding this comment.
To be changed with Geth implementation
…tiaorg#112) * adds orchestrator address to validator initialization in staking module * fix msg edit validator * todo * todo
…tiaorg#112) * adds orchestrator address to validator initialization in staking module * fix msg edit validator * todo * todo
…tiaorg#112) * adds orchestrator address to validator initialization in staking module * fix msg edit validator * todo * todo
adds orchestrator address to validator in staking module