Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Utilize SMT store in cosmos-sdk app #111 #241

Closed
wants to merge 14 commits into from

Conversation

Manav-Aggarwal
Copy link
Member

Description

For Cevmos' Block Fraud Proofs we need to have a SMT based store. We want to try and backport the one from v0.46.x.

Utilize SMT in Baseapp - follow up to #231

Closes: #111


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Manav-Aggarwal Manav-Aggarwal added C: Cevmos Changes related to the cevmos branches block-fraud-proofs Block Fraud Proofs (Generation and verification) labels Jul 22, 2022
@Manav-Aggarwal Manav-Aggarwal linked an issue Jul 22, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/backport_smt-utilize branch 2 times, most recently from ecb4911 to 39e3a74 Compare July 22, 2022 06:49
@Manav-Aggarwal Manav-Aggarwal changed the title feat: Utilize SMT store in Baseapp #111 feat: Utilize SMT store in cosmos-sdk app #111 Jul 22, 2022
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/backport_smt-utilize branch 2 times, most recently from 0a16fc3 to 02727dc Compare July 22, 2022 09:06
@Manav-Aggarwal Manav-Aggarwal self-assigned this Jul 22, 2022
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/backport_smt-utilize branch 2 times, most recently from fed44e3 to 5016042 Compare July 25, 2022 07:37
@Manav-Aggarwal
Copy link
Member Author

Since cosmos-sdk v0.46 supports tendermint v0.34 now, this PR is not needed. We'll be closing this PR and prioritizing #245 directly in cosmos-sdk 0.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-fraud-proofs Block Fraud Proofs (Generation and verification) C: Cevmos Changes related to the cevmos branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize SMT store in cosmos-sdk app
1 participant