forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Transition fraud proof prototype from block fraud proofs to fraud proof with ISRs #264
Closed
Manav-Aggarwal
wants to merge
118
commits into
manav/e2e-test-fraudproof-prototype
from
manav/fraudproof_with_isrs
Closed
feat: Transition fraud proof prototype from block fraud proofs to fraud proof with ISRs #264
Manav-Aggarwal
wants to merge
118
commits into
manav/e2e-test-fraudproof-prototype
from
manav/fraudproof_with_isrs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2d4db3.
Manav-Aggarwal
changed the title
FraudProof with ISRs
Transition fraud proof prototype from block fraud proofs to fraud proof with ISRs
Aug 20, 2022
Manav-Aggarwal
changed the title
Transition fraud proof prototype from block fraud proofs to fraud proof with ISRs
feat: Transition fraud proof prototype from block fraud proofs to fraud proof with ISRs
Aug 20, 2022
…erpret operations
… back when merging
Manav-Aggarwal
force-pushed
the
manav/fraudproof_with_isrs
branch
from
August 20, 2022 05:27
e1a01e7
to
5c89e85
Compare
everything is moved to cosmos-sdk-rollmint repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#245 covers the block fraud-proof prototype, we'd like to make it compatible with ISRs. It'd modify the cycle of a fraudproof to look like this:
Specifically, we cover this part of the cycle by modifying the existing TestGenerateAndLoadFraudProof:
The fast-forward parts by Optimint should be just simulated in the test.
Also covers:
Closes: #265
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change