Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cosmetics before the merge #277

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions x/auth/client/testutil/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -646,16 +646,15 @@ func (s *IntegrationTestSuite) TestCLIQueryTxsCmdByEvents() {
expectEmpty bool
expectError string
}{
{ // Multiple shares failing test
{
"fee event happy case",
[]string{
fmt.Sprintf("--events=tx.fee=%s",
sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10))).String()),
fmt.Sprintf("--%s=json", tmcli.OutputFlag),
},
false,
"transaction spanned more than two shares, this is not yet supported",
// TODO: change this to not expect an error when functionality is added to celestia-core
"",
},
{
"no matching fee event",
Expand Down
3 changes: 2 additions & 1 deletion x/staking/simulation/operations.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ func SimulateMsgCreateValidator(ak types.AccountKeeper, bk types.BankKeeper, k k

orchAddr := simAccount.Address
// create an Ethereum address from the orchestrator address
// this is mainly to have a deterministic way of generating an Ethereum address on every run // to have a long enough bytes array
// this is mainly to have a deterministic way of generating an Ethereum address on every run
// to have a long enough bytes array
ethAddr := common.HexToAddress("0x" + fmt.Sprintf("%X", simAccount.Address.Bytes()))

msg, err := types.NewMsgCreateValidator(address, simAccount.ConsKey.PubKey(), selfDelegation, description, commission, sdk.OneInt(), orchAddr, ethAddr)
Expand Down