chore: Update the default genesis params #285

evan-forbes · 2022-11-16T19:56:31Z

Description

During the onsite, we came to a few decisions around selecting a few genesis params. Given how easy they are to change, this PR changes the defaults to the values that we agreed upon. While this increases our diff slightly from upstream, it also will also help us keep params consistent across networks without having to configure them each time.

NOTE: we should not merge this PR, although we are keeping it open to continue the discussion around defualt params

closes celestiaorg/celestia-app#169

evan-forbes · 2022-11-16T19:58:01Z

x/auth/types/params.go

-	DefaultMaxMemoCharacters      uint64 = 256
+	DefaultMaxMemoCharacters      uint64 = 128


this cuts the max memo in half. The memo is now 1/4 the size of a single share, and costs 25% more per gas (10 gas/byte vs 8 gas/ blob byte)

I think we can explore how the memo is currently used. And limit the number to the minimum necessary. also, In celestia people can exchange messages directly in the blobs instead of the memo field.

evan-forbes · 2022-11-16T19:58:57Z

x/mint/types/params.go

-		InflationRateChange: sdk.NewDecWithPrec(13, 2),
-		InflationMax:        sdk.NewDecWithPrec(20, 2),
-		InflationMin:        sdk.NewDecWithPrec(7, 2),
+		InflationRateChange: sdk.NewDecWithPrec(1, 2),
+		InflationMax:        sdk.NewDecWithPrec(2, 2),
+		InflationMin:        sdk.NewDecWithPrec(2, 2),


Here we are changing the inflation to a flat 2% across the board.

evan-forbes · 2022-11-16T20:01:09Z

x/slashing/types/params.go

-	DefaultSignedBlocksWindow   = int64(100)
+	DefaultSignedBlocksWindow   = int64(5760)


here we are changing the defaults window from 100 blocks to roughly the number of blocks per day assuming 4 blocks a minute. (24 * 60 * 4)

How is this parameter used by the Cosmos SDK?

its used when slashing for liveness. If a validator misses a certain percentage of signatures in this window, they will be jailed and slashed. Currently its 50%, so validators will be slashed if they miss roughly half the signatures in one day.

the parameter spec

docs

source

cosmos-sdk/x/slashing/keeper/infractions.go

Lines 72 to 87 in d11c222

minHeight := signInfo.StartHeight + k.SignedBlocksWindow(ctx)

maxMissed := k.SignedBlocksWindow(ctx) - minSignedPerWindow

// if we are past the minimum height and the validator has missed too many blocks, punish them

if height > minHeight && signInfo.MissedBlocksCounter > maxMissed {

validator := k.sk.ValidatorByConsAddr(ctx, consAddr)

if validator != nil && !validator.IsJailed() {

// Downtime confirmed: slash and jail the validator

// We need to retrieve the stake distribution which signed the block, so we subtract ValidatorUpdateDelay from the evidence height,

// and subtract an additional 1 since this is the LastCommit.

// Note that this *can* result in a negative "distributionHeight" up to -ValidatorUpdateDelay-1,

// i.e. at the end of the pre-genesis block (none) = at the beginning of the genesis block.

// That's fine since this is just used to filter unbonding delegations & redelegations.

distributionHeight := height - sdk.ValidatorUpdateDelay - 1

coinsBurned := k.sk.Slash(ctx, consAddr, distributionHeight, power, k.SlashFractionDowntime(ctx))

evan-forbes · 2022-11-16T20:01:38Z

x/staking/types/params.go

-var DefaultMinCommissionRate = sdk.ZeroDec()
+var DefaultMinCommissionRate = sdk.NewDecWithPrec(5, 2)


All validators will have to have a minimum commission rate of 5%

rootulp

Only one blocking comment

x/staking/types/params.go

x/slashing/types/params.go

x/mint/types/params.go

Co-authored-by: Rootul P <rootulp@gmail.com>

rootulp

🚀

musalbas · 2022-11-16T23:03:47Z

x/mint/types/params.go

-		InflationMin:        sdk.NewDecWithPrec(7, 2),
+		InflationRateChange: sdk.ZeroDec(),
+		InflationMax:        sdk.NewDecWithPrec(2, 2),
+		InflationMin:        sdk.NewDecWithPrec(2, 2),


We have not made any decision on the inflation parameters yet. It likely won't be 2% fixed though as that's probably too low.

Ok, good to know.

this was initially changed because of our notes indicated heading in this direction (lower the percentage and keep it fixed)

Decided
we want a lower value for inflation
we want to set inflation max and inflation min to the same value
Undecided
the exact values for inflation are tbd

reverted here ea05762 and we can just rely on changing these params manually per network until we decide on values

We do want to reduce the values for inflation - but exact values are tbd as stated in notes

My thinking for inflation is a 3-5 % range (not flat). But we will decide this soonish.

musalbas · 2022-11-16T23:04:08Z

x/mint/types/params.go

-		InflationRateChange: sdk.NewDecWithPrec(13, 2),
-		InflationMax:        sdk.NewDecWithPrec(20, 2),
-		InflationMin:        sdk.NewDecWithPrec(7, 2),
+		InflationRateChange: sdk.ZeroDec(),


What does this do?

setting to zero doesn't allow for the inflation rate to change.

Note that this was set to 100% or 1 on the hub not too long ago. Zaki has some charts for rationale here.

musalbas · 2022-11-16T23:07:06Z

x/mint/types/params.go

 		GoalBonded:          sdk.NewDecWithPrec(67, 2),
-		BlocksPerYear:       uint64(60 * 60 * 8766 / 5), // assuming 5 second block times
+		BlocksPerYear:       uint64(60 * 60 * 8766 / 15), // assuming 15 second block times


How is this used by the Cosmos SDK? Got a link to docs maybe?

blocks per year is used to determine the rate of change for inflation (we currently have the max inflation rate change set to 0, so this value shouldn't be important unless we ever change it)

https://docs.cosmos.network/main/modules/mint

liamsi

Is it not possible to change all these in the app instead? Couldn't we wrap the default modules, change the defaults in the respective wrappers, and use these wrapped modules instead of the default ones? That way we do not need to modify the SDK itself.

That said, this PR is super useful to align on the actual params.

evan-forbes · 2022-11-23T19:54:05Z

Couldn't we wrap the default modules, change the defaults in the respective wrappers, and use these wrapped modules instead of the default ones?

yeah we definitely can do that. initially I didn't do that as it will add even more boiler plate, but I think we'll have to to avoid breaking a bunch of tests

evan-forbes · 2022-11-23T19:54:39Z

keeping this open for now, as I would like to continue the review process and discussions. but we shouldn't merge

evan-forbes added 4 commits November 16, 2022 13:06

chore: update the default mint params

6172672

chore: update the slashing modules default params

938aa8d

chore: update the default staking module params

8e25e29

chore: update the default params for the auth module

94e00fd

evan-forbes added C: app Changes related to the celestia-app branches C:x/auth C:x/slashing C:x/staking labels Nov 16, 2022

evan-forbes requested review from adlerjohn, rootulp, musalbas, liamsi, rahulghangas and rach-id November 16, 2022 19:56

evan-forbes self-assigned this Nov 16, 2022

evan-forbes commented Nov 16, 2022

View reviewed changes

rootulp requested changes Nov 16, 2022

View reviewed changes

x/staking/types/params.go Outdated Show resolved Hide resolved

x/slashing/types/params.go Outdated Show resolved Hide resolved

x/mint/types/params.go Outdated Show resolved Hide resolved

evan-forbes and others added 2 commits November 16, 2022 14:25

chore: add docs to default changes

0215173

Co-authored-by: Rootul P <rootulp@gmail.com>

chore: use zero dec for inflation rate change

0e05cb2

rootulp approved these changes Nov 16, 2022

View reviewed changes

rach-id approved these changes Nov 16, 2022

View reviewed changes

musalbas reviewed Nov 16, 2022

View reviewed changes

chore: revert mint module default params changes

ea05762

liamsi reviewed Nov 22, 2022

View reviewed changes

evan-forbes marked this pull request as draft November 23, 2022 19:57

evan-forbes mentioned this pull request Nov 24, 2022

Define genesis params celestiaorg/celestia-app#169

Closed

evan-forbes closed this May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update the default genesis params #285

chore: Update the default genesis params #285

evan-forbes commented Nov 16, 2022 •

edited

Loading

evan-forbes Nov 16, 2022

liamsi Nov 22, 2022

evan-forbes Nov 16, 2022

evan-forbes Nov 16, 2022 •

edited

Loading

musalbas Nov 16, 2022

evan-forbes Nov 17, 2022

evan-forbes Nov 16, 2022

rootulp left a comment

rootulp left a comment

musalbas Nov 16, 2022

evan-forbes Nov 17, 2022

evan-forbes Nov 17, 2022

musalbas Nov 17, 2022

liamsi Nov 22, 2022

musalbas Nov 16, 2022

evan-forbes Nov 17, 2022

liamsi Nov 22, 2022

musalbas Nov 16, 2022

evan-forbes Nov 17, 2022

liamsi left a comment •

edited

Loading

evan-forbes commented Nov 23, 2022

evan-forbes commented Nov 23, 2022

		DefaultMaxMemoCharacters uint64 = 256
		DefaultMaxMemoCharacters uint64 = 128

		DefaultSignedBlocksWindow = int64(100)
		DefaultSignedBlocksWindow = int64(5760)

	minHeight := signInfo.StartHeight + k.SignedBlocksWindow(ctx)
	maxMissed := k.SignedBlocksWindow(ctx) - minSignedPerWindow

	// if we are past the minimum height and the validator has missed too many blocks, punish them
	if height > minHeight && signInfo.MissedBlocksCounter > maxMissed {
	validator := k.sk.ValidatorByConsAddr(ctx, consAddr)
	if validator != nil && !validator.IsJailed() {
	// Downtime confirmed: slash and jail the validator
	// We need to retrieve the stake distribution which signed the block, so we subtract ValidatorUpdateDelay from the evidence height,
	// and subtract an additional 1 since this is the LastCommit.
	// Note that this can result in a negative "distributionHeight" up to -ValidatorUpdateDelay-1,
	// i.e. at the end of the pre-genesis block (none) = at the beginning of the genesis block.
	// That's fine since this is just used to filter unbonding delegations & redelegations.
	distributionHeight := height - sdk.ValidatorUpdateDelay - 1

	coinsBurned := k.sk.Slash(ctx, consAddr, distributionHeight, power, k.SlashFractionDowntime(ctx))

		var DefaultMinCommissionRate = sdk.ZeroDec()
		var DefaultMinCommissionRate = sdk.NewDecWithPrec(5, 2)

chore: Update the default genesis params #285

chore: Update the default genesis params #285

Conversation

evan-forbes commented Nov 16, 2022 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evan-forbes Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rootulp left a comment

Choose a reason for hiding this comment

rootulp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamsi left a comment • edited Loading

Choose a reason for hiding this comment

evan-forbes commented Nov 23, 2022

evan-forbes commented Nov 23, 2022

evan-forbes commented Nov 16, 2022 •

edited

Loading

evan-forbes Nov 16, 2022 •

edited

Loading

liamsi left a comment •

edited

Loading