forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade to prometheus/common
v0.53.0
#401
Merged
rootulp
merged 5 commits into
celestiaorg:release/v0.46.x-celestia
from
rootulp:rp/bump-prometheus-client
May 31, 2024
Merged
chore(deps): upgrade to prometheus/common
v0.53.0
#401
rootulp
merged 5 commits into
celestiaorg:release/v0.46.x-celestia
from
rootulp:rp/bump-prometheus-client
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rootulp
requested review from
cmwaters,
ninabarbakadze and
evan-forbes
and removed request for
a team and
cmwaters
May 29, 2024 19:10
Wondertan
reviewed
May 29, 2024
@@ -21,6 +21,7 @@ const ( | |||
FormatDefault = "" | |||
FormatPrometheus = "prometheus" | |||
FormatText = "text" | |||
ContentTypeText = `text/plain; version=` + expfmt.TextVersion + `; charset=utf-8` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this copied from cosmos-sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondertan
approved these changes
May 29, 2024
evan-forbes
approved these changes
May 29, 2024
rach-id
approved these changes
May 31, 2024
ninabarbakadze
approved these changes
May 31, 2024
rootulp
merged commit May 31, 2024
83c372b
into
celestiaorg:release/v0.46.x-celestia
26 of 27 checks passed
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
May 31, 2024
Closes #3448 Unblocks celestia-node because this cosmos-sdk release contains celestiaorg/cosmos-sdk#401 which should let celestia-node upgrade their `prometheus/common` dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400