Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to prometheus/common v0.53.0 #401

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 27, 2024

Closes #400

@rootulp rootulp self-assigned this May 27, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented May 29, 2024

make lint on my machine spun endlessly and CI make lint doesn't contain any helpful info on why it failed so retrying.

@rootulp rootulp marked this pull request as ready for review May 29, 2024 19:10
@rootulp rootulp requested a review from a team as a code owner May 29, 2024 19:10
@rootulp rootulp requested review from cmwaters, ninabarbakadze and evan-forbes and removed request for a team and cmwaters May 29, 2024 19:10
@@ -21,6 +21,7 @@ const (
FormatDefault = ""
FormatPrometheus = "prometheus"
FormatText = "text"
ContentTypeText = `text/plain; version=` + expfmt.TextVersion + `; charset=utf-8`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this copied from cosmos-sdk?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootulp rootulp requested review from cmwaters and staheri14 May 31, 2024 15:06
@rootulp rootulp merged commit 83c372b into celestiaorg:release/v0.46.x-celestia May 31, 2024
26 of 27 checks passed
@rootulp rootulp deleted the rp/bump-prometheus-client branch May 31, 2024 15:14
rootulp added a commit to celestiaorg/celestia-app that referenced this pull request May 31, 2024
Closes #3448
Unblocks celestia-node because this cosmos-sdk release contains
celestiaorg/cosmos-sdk#401 which should let
celestia-node upgrade their `prometheus/common` dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prometheus Client
5 participants