-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor dalc into celestia-node plugin #55
Conversation
we are currently experiencing this bug, as we are using the latest version of celestia-node here. We will either need to change to a stable version, or update as soon as this is fixed. what do we think? wait or downgrade? Everything seems to be working, an error is just thrown |
Depends on the timeline of fixing the mentioned issue. What's the timeline? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Looks fine.
I would merge this and keep an eye on celestiaorg/celestia-node#511. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile (build function), docker/Dockerfile, and entrypoint.sh should be updated.
For Makefile.build you need to do go build ./cmd/celestia
entrypoint.sh needs to be changed to if [ "$1" = 'celestia' ]; then
on line 5
The Dockerfile needs to copy from /dalc/celestia
to /root/celestia
on line 17 and line 24 needs to be CMD ["celestia"]
.
I'm getting the following errors when attempting to run this as a docker container
it sounds like the header/sync error is expected. Is the |
I don't know if that's related or not, but it does occur running the normal celestia-node (latest commit main) on devnet. While we might want to merge this version to master, considering the current issues, I think we should definitely create a version of the plugin/dalc based on the latest stable release of celestia-node as well. That way we can feel more comfortable pointing potential devs to it, while also having a version that we can test the latest and greatest on. |
Description
The dalc needs access to certain celestia-node internals. This PR is using the plugin mechanism introduced in (unmerged) #407 to better integrate with celestia-node, and refactor the dalc's celestia-node usage to fully utilize preexisting components.
This is a short term solution. In the future we will likely use native celestia-node instead of wrapping it here. After connecting this to devnet, I can confirm that this is significantly easier to use than before. The setup is identical to a normal celestia-node setup, with the addtional
optimint-server.toml
config file added.closes #51