Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making figures consistent in the blobstream intro #1271

Closed
staheri14 opened this issue Nov 16, 2023 · 2 comments · Fixed by #1261
Closed

making figures consistent in the blobstream intro #1271

staheri14 opened this issue Nov 16, 2023 · 2 comments · Fixed by #1261
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@staheri14
Copy link
Collaborator

staheri14 commented Nov 16, 2023

In the intro to blobstream, two figures are supplied one as the continuation of the other i.e.,

https://docs.celestia.org/img/blobstream/blobstream-orchestrator.png

and

https://docs.celestia.org/img/blobstream/blobstream-relayer.png

The first image illustrates that attestations are coming from the celestia validator node, while in the second figure the source of attestations changes to the celestia app consensus node. If this discrepancy is not intentional, then it is worth updating the figures to make them consistent.

@staheri14
Copy link
Collaborator Author

staheri14 commented Nov 16, 2023

A minor side note: there is also a discrepancy in coloring between the validator node and the Celestia app consensus node in the two figures. They could become consistent in terms of color as well.

@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2023
@jcstein
Copy link
Member

jcstein commented Nov 17, 2023

thank you for this issue! i plan to remove these older diagrams in favor of the newer version in the top of the overview section and also reworking the intro pages (https://docs.celestia.org/developers/blobstream & https://docs.celestia.org/nodes/blobstream-intro) based on this from github. i'll also find a home for the diagrams from succint that are still a WIP and will be added after the first revision of blobstream docs

@jcstein jcstein self-assigned this Nov 17, 2023
jcstein added a commit that referenced this issue Nov 17, 2023
Resolves #1271
Resolves #1275 partially
@jcstein jcstein mentioned this issue Nov 17, 2023
7 tasks
jcstein added a commit that referenced this issue Nov 20, 2023
* chore: update to mocha for blobstream

* chore: rework blobstream intros

Resolves #1271
Resolves #1275 partially

* fix: autformatting

* chore: pull in orch-relayer docs updates

* chore: add mocha bootstrapper

* chore: add import of blobstream-bootstrapper doc

* chore: copy edits

* chore: rearrange blobstream.md

* feat: add bootstrapper doc

* Update nodes/blobstream-binary.md

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rootul P <rootulp@gmail.com>

* Update nodes/blobstream-orchestrator.md

Co-authored-by: Rootul P <rootulp@gmail.com>

* chore: pull in blobstream updates

Co-Authored-By: Rootul P <rootulp@gmail.com>

---------

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants