Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update QGB docs from source #1078

Merged
merged 2 commits into from
Oct 3, 2023
Merged

chore: update QGB docs from source #1078

merged 2 commits into from
Oct 3, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Sep 21, 2023 •
edited
Loading

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from rach-id September 21, 2023 15:50
@jcstein jcstein self-assigned this Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1078/
on branch gh-pages at 2023-09-21 20:37 UTC

rach-id
rach-id reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we wait for this celestiaorg/orchestrator-relayer#492 to be merged too? so that it's clear to validatos that they need to register an EVM address

@rach-id
Copy link
Member

rach-id commented Sep 21, 2023

merged, can we update the docs in this PR now?

@jcstein
Copy link
Member Author

jcstein commented Sep 21, 2023

absolutely. it's been updated in fc01874

@jcstein jcstein requested a review from rach-id September 21, 2023 20:37
@jcstein
Copy link
Member Author

jcstein commented Sep 21, 2023

FYI @Bidon15 i plan to wait to merge this until rc17 is live on mocha

@jcstein jcstein marked this pull request as draft September 22, 2023 16:57
@jcstein
Copy link
Member Author

jcstein commented Oct 3, 2023

should this be made live in the docs? @sweexordious

@rach-id
Copy link
Member

rach-id commented Oct 3, 2023

Sure, thanks 👍 👍

@jcstein jcstein marked this pull request as ready for review October 3, 2023 15:11
@jcstein jcstein merged commit 00aa3c3 into main Oct 3, 2023
@jcstein jcstein deleted the jcs/update-qgb branch October 3, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

Assignees

@jcstein jcstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcstein @rach-id