-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docker cmds #1769
docs: update docker cmds #1769
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe document Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- how-to-guides/docker-images.md (1 hunks)
🔇 Additional comments (3)
how-to-guides/docker-images.md (3)
221-221
: Same variable inconsistency issue as above.The command uses undefined
$P2P_NETWORK
instead of the defined$NETWORK
variable.
228-228
: Same variable inconsistency issue as above.The command uses undefined
$P2P_NETWORK
instead of the defined$NETWORK
variable.
214-228
: Verify the impact of p2p network parameter addition.While adding the
--p2p.network
parameter is a good improvement, let's verify that this parameter is required and properly documented in the node's configuration guide.✅ Verification successful
Based on the search results, I can now generate the final response as there is sufficient evidence to verify the usage of the
--p2p.network
parameter.The
--p2p.network
parameter is correctly implemented and well-documentedThe parameter is extensively documented across multiple guides and tutorials, showing consistent usage patterns for different networks:
- Mainnet Beta: Optional (defaults to "celestia")
- Mocha testnet: Required with
--p2p.network mocha
- Arabica devnet: Required with
--p2p.network arabica
The implementation in the docker commands aligns with the established patterns found throughout the documentation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for p2p.network parameter documentation in other files rg --type md "p2p.network" --glob '!how-to-guides/docker-images.md'Length of output: 7871
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Overview
Resolves #1771
Summary by CodeRabbit
New Features
Documentation