-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial QGB Docs #279
Add initial QGB Docs #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome first iterations 🔥
Left some comments and suggestions
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second pass, added more suggestions
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@sweexordious I think it does make sense to include, but maybe not for first iteration so we can push this live? |
@jcstein Yes, 100%, sounds good, we can remember it or create an issue for it. |
adding suggestions from @sweexordious Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@sweexordious where can we find examples of running a local version of the QGB? Is it the init-chain.sh or docker-compose build or both? Happy to add them to the PR. |
Which do you prefer? A network where they have to run similar to running a validator? |
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some logs + how to run details
Thank you, I'll review when back home @sweexordious! |
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
### Starting the Orchestrator | ||
|
||
With your celestia-app Validator running in one Terminal session, open a new | ||
Terminal session in order to run the Orchestrator. | ||
|
||
You can run the following command to start the Orchestrator: | ||
|
||
<!-- markdownlint-disable MD013 --> | ||
```sh | ||
celestia-appd orchestrator -x "mocha" -d <EVM-PRIVATE-KEY> --keyring-account validator --keyring-backend=test | ||
``` | ||
<!-- markdownlint-enable MD013 --> | ||
|
||
The `-x` flag references the chain-id of the Celestia network. Here, we are | ||
connecting it to Mocha Testnet so we are using `mocha`. | ||
|
||
The `-d` flag refers to your EVM Private Key that will be used to sign the | ||
transactions. | ||
|
||
`keyring-account` refers to the validator key name on Celestia. | ||
|
||
Running the orchestrator command above will show logs like the following | ||
output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sweexordious should anyone be running the orchestrator? I was under the impressing that the only people running the QGB would be us until v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point 👍 👍. This was written before we decided to have a separate testnet for the QGB.
So, we can remove these docs from here, and keep them somewhere until we start the QGB dedicated testnet. Thanks a lot for flagging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, should i leave out lines 81-268 out for V1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 👍 let's keep those somewhere because we will need them in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. will review with @YazzyYaz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to remove everything from ## Setting Up the QGB
(line 53) on @evan-forbes / @sweexordious / @YazzyYaz ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @YazzyYaz , but imo yeah. alternatively, we could just mention that we're not running the qgb on a testnet atm so these docs are not yet relevant. The end result for v2 will likely be similar, and this info is really good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, thank you Evan
version "7.16.7" | ||
resolved "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.16.7.tgz" | ||
integrity sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg== | ||
"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.10.4", "@babel/code-frame@^7.16.0", "@babel/code-frame@^7.18.6", "@babel/code-frame@^7.8.3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I think we can revert the changes here @YazzyYaz?
closing in favor of #668 |
* docs: add QGB docs * fix: anchor links in imported markdown, tables * style: add category under Validator for QGB * align with celestiaorg/orchestrator-relayer#295 * feat: add markdown import to build command * docs: update markdown files * add intro section TODO * reformat menu * docs: add intro section * fix: linting from source as test * add back QGB to titles for clarity * edit copy of intro * update from source * manually add changes from celestiaorg/orchestrator-relayer#334 * add intro and diagrams from #279 * linting * add "install" section, add variable for QGB for golang, and link to internal pages * match celestiaorg/orchestrator-relayer#337
* docs: add QGB docs * fix: anchor links in imported markdown, tables * style: add category under Validator for QGB * align with celestiaorg/orchestrator-relayer#295 * feat: add markdown import to build command * docs: update markdown files * add intro section TODO * reformat menu * docs: add intro section * fix: linting from source as test * add back QGB to titles for clarity * edit copy of intro * update from source * manually add changes from celestiaorg/orchestrator-relayer#334 * add intro and diagrams from #279 * linting * add "install" section, add variable for QGB for golang, and link to internal pages * match celestiaorg/orchestrator-relayer#337
Closes #222
Things Left To Do: