Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial QGB Docs #279

Closed
wants to merge 14 commits into from
Closed

Add initial QGB Docs #279

wants to merge 14 commits into from

Conversation

YazzyYaz
Copy link
Contributor

@YazzyYaz YazzyYaz commented Oct 31, 2022

Closes #222

Things Left To Do:

  • Update Mockups
  • Show Logs
  • Show EVM Key Generation
  • Show local QGB Network Instantiation

@YazzyYaz YazzyYaz added the documentation Improvements or additions to documentation label Oct 31, 2022
@YazzyYaz YazzyYaz self-assigned this Oct 31, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome first iterations 🔥
Left some comments and suggestions

docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Show resolved Hide resolved
@jcstein
Copy link
Member

jcstein commented Oct 31, 2022

image (1)


image (2)


image (3)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

PR Preview Action v1.2.0
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-279/
on branch gh-pages at 2022-10-31 21:35 UTC

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second pass, added more suggestions

docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@rach-id
Copy link
Member

rach-id commented Nov 1, 2022

@YazzyYaz @jcstein does it make sense to add a section where you can run a local version of the QGB? Or this should belong in the repo?

@jcstein
Copy link
Member

jcstein commented Nov 2, 2022

@sweexordious I think it does make sense to include, but maybe not for first iteration so we can push this live?

@rach-id
Copy link
Member

rach-id commented Nov 2, 2022

@jcstein Yes, 100%, sounds good, we can remember it or create an issue for it.

adding suggestions from @sweexordious

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@YazzyYaz
Copy link
Contributor Author

YazzyYaz commented Nov 2, 2022

@sweexordious where can we find examples of running a local version of the QGB?

Is it the init-chain.sh or docker-compose build or both? Happy to add them to the PR.

@rach-id
Copy link
Member

rach-id commented Nov 2, 2022

Which do you prefer? A network where they have to run similar to running a validator?
Or an automatic docker compose script that starts with a single command and spins up eveytuing automatically?

YazzyYaz and others added 2 commits November 2, 2022 18:19
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some logs + how to run details

docs/nodes/qgb.md Show resolved Hide resolved
docs/nodes/qgb.md Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
docs/nodes/qgb.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member

jcstein commented Nov 5, 2022

Thank you, I'll review when back home @sweexordious!

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Comment on lines +81 to +103
### Starting the Orchestrator

With your celestia-app Validator running in one Terminal session, open a new
Terminal session in order to run the Orchestrator.

You can run the following command to start the Orchestrator:

<!-- markdownlint-disable MD013 -->
```sh
celestia-appd orchestrator -x "mocha" -d <EVM-PRIVATE-KEY> --keyring-account validator --keyring-backend=test
```
<!-- markdownlint-enable MD013 -->

The `-x` flag references the chain-id of the Celestia network. Here, we are
connecting it to Mocha Testnet so we are using `mocha`.

The `-d` flag refers to your EVM Private Key that will be used to sign the
transactions.

`keyring-account` refers to the validator key name on Celestia.

Running the orchestrator command above will show logs like the following
output:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sweexordious should anyone be running the orchestrator? I was under the impressing that the only people running the QGB would be us until v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍 👍. This was written before we decided to have a separate testnet for the QGB.
So, we can remove these docs from here, and keep them somewhere until we start the QGB dedicated testnet. Thanks a lot for flagging this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, should i leave out lines 81-268 out for V1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 👍 let's keep those somewhere because we will need them in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. will review with @YazzyYaz

Copy link
Member

@jcstein jcstein Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to remove everything from ## Setting Up the QGB (line 53) on @evan-forbes / @sweexordious / @YazzyYaz ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @YazzyYaz , but imo yeah. alternatively, we could just mention that we're not running the qgb on a testnet atm so these docs are not yet relevant. The end result for v2 will likely be similar, and this info is really good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thank you Evan

version "7.16.7"
resolved "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.16.7.tgz"
integrity sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg==
"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.10.4", "@babel/code-frame@^7.16.0", "@babel/code-frame@^7.18.6", "@babel/code-frame@^7.8.3":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I think we can revert the changes here @YazzyYaz?

@YazzyYaz YazzyYaz marked this pull request as draft January 10, 2023 18:37
@jcstein jcstein mentioned this pull request Apr 25, 2023
17 tasks
jcstein added a commit that referenced this pull request Apr 28, 2023
@jcstein
Copy link
Member

jcstein commented Apr 28, 2023

closing in favor of #668

@jcstein jcstein closed this Apr 28, 2023
jcstein added a commit that referenced this pull request Apr 28, 2023
* docs: add QGB docs

* fix: anchor links in imported markdown, tables

* style: add category under Validator for QGB

* align with celestiaorg/orchestrator-relayer#295

* feat: add markdown import to build command

* docs: update markdown files

* add intro section TODO

* reformat menu

* docs: add intro section

* fix: linting from source as test

* add back QGB to titles for clarity

* edit copy of intro

* update from source

* manually add changes from celestiaorg/orchestrator-relayer#334

* add intro and diagrams from #279

* linting

* add "install" section, add variable for QGB for golang, and link to internal pages

* match celestiaorg/orchestrator-relayer#337
@jcstein jcstein deleted the yaz.qgb_docs branch May 5, 2023 03:11
jcstein added a commit that referenced this pull request Sep 21, 2023
* docs: add QGB docs

* fix: anchor links in imported markdown, tables

* style: add category under Validator for QGB

* align with celestiaorg/orchestrator-relayer#295

* feat: add markdown import to build command

* docs: update markdown files

* add intro section TODO

* reformat menu

* docs: add intro section

* fix: linting from source as test

* add back QGB to titles for clarity

* edit copy of intro

* update from source

* manually add changes from celestiaorg/orchestrator-relayer#334

* add intro and diagrams from #279

* linting

* add "install" section, add variable for QGB for golang, and link to internal pages

* match celestiaorg/orchestrator-relayer#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Validator docs for Celestia-App 0.7.0 with QGB configs
4 participants