Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove methods from CLI tutorial that do not work currently #915

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jul 18, 2023

Overview

Resolves #914

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-915/
on branch gh-pages at 2023-07-19 10:14 UTC

@jcstein jcstein self-assigned this Jul 18, 2023
@jcstein jcstein requested a review from rootulp July 18, 2023 15:39
docs/developers/node-tutorial.mdx Outdated Show resolved Hide resolved
@jcstein jcstein merged commit 1433a71 into main Jul 19, 2023
3 checks passed
@jcstein jcstein deleted the jcs/remove-getshare branch July 19, 2023 10:12
@jcstein
Copy link
Member Author

jcstein commented Jul 27, 2023

cc @vgonkivs - i think i will just add back GetSharesByNamespace once it is in a live version :) and i recall @renaynay recommended to take out GetShares for now, and maybe for good :)

celestia rpc share GetSharesByNamespace "$(celestia rpc header GetByHeight 103692 | jq '.result.dah' -r)" 0x42690c204d39600fddd3
{
  "jsonrpc": "2.0",
  "result": [
    {
      "Shares": [
        "AAAAAAAAAAAAAAAAAAAAAAAAAEJpDCBNOWAP3dMBAAAACEltZHRJZz09AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
      ],
      "Proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABHBoPeolnLUCIgDXv2uScYcpg3V/gJIIwil8j33b33eH",
          "/////////////////////////////////////////////////////////////////////////////4S2andMgMf77TuFT8NmQm5qoIqmmDsUmUHKwGCZ+wg0"
        ],
        "leaf_hash": null,
        "is_max_namespace_id_ignored": true
      }
    }
  ],
  "id": 1
}

jcstein added a commit that referenced this pull request Sep 21, 2023
* Update node-tutorial.mdx

* Update node-tutorial.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getshare and getsharesbynamespace don't work
2 participants