Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p2p): implement retry mechanism for Head request #149

Open
vgonkivs opened this issue Jan 26, 2024 · 3 comments
Open

fix(p2p): implement retry mechanism for Head request #149

vgonkivs opened this issue Jan 26, 2024 · 3 comments
Labels
bug Something isn't working p2p

Comments

@vgonkivs
Copy link
Member

Head method should have its default timeout for all requests(if it wasn't set) and in case we receive less than 3/4 of a positive response, we should ask more peers to determine the current Head.
Note: we should implement retry only for tracked peers. For the trusted peers - only timeout will be enough.

@AryanGodara
Copy link
Contributor

This one was mentioned in #152, so is this issue partially completed now?

@Wondertan
Copy link
Member

No, this is a follow-up issue from that PR. Unfinished work that deferred for later, but you are free to give it a try!

@AryanGodara
Copy link
Contributor

Agreed. @AryanGodara, I suggest looking at #149 instead

Thanks, @Wondertan! I'd very much like to work on this issue :)
I can get started with it only on Monday, though :(
In the meantime, could you please assign this one to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2p
Projects
None yet
Development

No branches or pull requests

3 participants