Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should GetVerifiedRangeByHeight return the first item of the range? #72

Closed
oblique opened this issue Jul 9, 2023 · 3 comments · Fixed by celestiaorg/celestia-node#2826
Assignees

Comments

@oblique
Copy link

oblique commented Jul 9, 2023

The RPC docs of GetVerifiedRangeByHeight state that [from,to) range is returned, however the first item (i.e. from) is not included in the result. My first guess was that this was because we already know it.

Is this a bug in the implementation or in the docs? What is the expected behavior?

@vgonkivs
Copy link
Member

hello @oblique. Thanks for posting the issue. Yes, your initial assumption is correct - from should be non-inclusive in case of requesting GetVerifiedRangeByHeight. Will fix this issue in celestia-node documentation.

@Wondertan
Copy link
Member

@vgonkivs, should we close this one?

@Wondertan
Copy link
Member

Wondertan commented Oct 9, 2023

cc @vgonkivs, I checked that we haven't fixed it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants