Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix GetVerifiedRange doc #2826

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(docs): fix GetVerifiedRange doc #2826

merged 1 commit into from
Oct 9, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Oct 9, 2023

Overview

Fixes celestiaorg/go-header#72

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added docs:godocs Related to documentation of packages / code kind:fix Attached to bug-fixing PRs labels Oct 9, 2023
@vgonkivs vgonkivs self-assigned this Oct 9, 2023
@vgonkivs vgonkivs enabled auto-merge (squash) October 9, 2023 13:51
@vgonkivs vgonkivs disabled auto-merge October 9, 2023 14:15
@ramin ramin self-requested a review October 9, 2023 14:19
@vgonkivs vgonkivs merged commit a2cf93d into celestiaorg:main Oct 9, 2023
14 of 16 checks passed
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@liamsi liamsi liamsi approved these changes

@walldiss walldiss walldiss approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@Wondertan Wondertan Wondertan approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn adlerjohn is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

Assignees

@vgonkivs vgonkivs

Labels
docs:godocs Related to documentation of packages / code kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should GetVerifiedRangeByHeight return the first item of the range?
6 participants
@vgonkivs @ramin @liamsi @walldiss @distractedm1nd @Wondertan