Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2p): Head requests respects SoftFailure during Verify check #109

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix(p2p): Head requests respects SoftFailure during Verify check #109

merged 2 commits into from
Sep 25, 2023

Conversation

renaynay
Copy link
Member

Resolves #105

@renaynay renaynay requested a review from tzdybal as a code owner September 20, 2023 12:06
@renaynay renaynay self-assigned this Sep 20, 2023
vgonkivs
vgonkivs previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

walldiss
walldiss previously approved these changes Sep 22, 2023
View reviewed changes
@renaynay renaynay dismissed stale reviews from walldiss and vgonkivs via 19ecd5b September 22, 2023 14:07
@renaynay renaynay enabled auto-merge September 25, 2023 12:45
@renaynay renaynay merged commit ab6c2f5 into celestiaorg:main Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@vgonkivs vgonkivs vgonkivs left review comments

@walldiss walldiss walldiss left review comments

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees

@renaynay renaynay

Labels
kind:fix p2p
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p2p: Use SoftFailure concept inside Head request to tracked peers
5 participants
@renaynay @walldiss @distractedm1nd @Wondertan @vgonkivs