Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
generating
theconfig.toml
used by thenodeType
configmap within themain
helm-chartcelestia-node
we delegate that responsibility tocommon-celestia-node
which is ahelm
library chart that enablesmodularity
. Ideally everything should be broken down intoreusable
modular blocks.After the first release of
common-node-type
we can fully remove the 3 existing configmaps:And have a single
configmap.yaml
that would simply contain thegenerator
helper function fromcommon-celestia-node
{{ include "common-celestia-node.configmap" . }}
main
Chart.yaml
configuration should be changed as:Visual diagram