Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common-celestia-node chart #62

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add common-celestia-node chart #62

merged 1 commit into from
Oct 17, 2024

Conversation

aWN4Y25pa2EK
Copy link
Contributor

@aWN4Y25pa2EK aWN4Y25pa2EK commented Oct 16, 2024

Instead of generating the config.toml used by the nodeType configmap within the main helm-chart celestia-node we delegate that responsibility to common-celestia-node which is a helm library chart that enables modularity. Ideally everything should be broken down into reusable modular blocks.

After the first release of common-node-type we can fully remove the 3 existing configmaps:

  1. configmap-bridge.yaml
  2. configmap-full.yaml
  3. configmap-light.yaml

And have a single configmap.yaml that would simply contain the generator helper function from common-celestia-node

{{ include "common-celestia-node.configmap" . }}

main Chart.yaml configuration should be changed as:

annotations:
  category: celestia
  licenses: Apache-2.0
apiVersion: v2
appVersion: v0.17.1
dependencies:
- name: common
  repository: oci://registry-1.docker.io/bitnamicharts
  tags:
  - bitnami-common
  version: 2.x.x
- name: common-celestia-node
  version: 0.1.0
  repository: https://celestiaorg.github.io/helm-charts
description: Celestia Node
home: https://celestia.org
icon: https://celestia.org/static/celestia-logo-29451ae35d3bb72cc4b0f17712d44c3a.svg
keywords:
  - celestia
  - celestia-node
maintainers:
  - name: Celestia Labs
    url: https://github.com/celestiaorg
name: celestia-node
sources:
  - https://github.com/celestiaorg/helm-charts
version: 0.8.0

Visual diagram

Screenshot 2024-10-16 at 16 24 12

Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You 🪨

@aWN4Y25pa2EK aWN4Y25pa2EK merged commit f2adcec into main Oct 17, 2024
1 of 2 checks passed
@aWN4Y25pa2EK aWN4Y25pa2EK deleted the lib-node-builder branch October 17, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants