Add path split for common-charts
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
reviewed
Oct 22, 2024
There was a problem hiding this comment.
utACK
fwiw action testing is unfortunately not well established. There are a few frameworks but they require a lot of set up and not very quick for iteration imo.
The best way I've found is to do all the testing on a personal repo that is all throw away stuff. Then you can play around with tons of configs and not worry about deploying errors to our registries.
MSevey
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The releaser doesn't have a logic to enable an order execution across multiple charts, since we want to always build first the
commoncharts which are thelibsof the main charts we are splitting the paths betweencommon-chartsandchartsthis way the order is hardcoded on areleaserworkflow level.