chore(deps): bump golangci/golangci-lint-action from 3 to 4 (#245)

Bumps
[golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action)
from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's
releases</a>.</em></p>
<blockquote>
<h2>v3.7.0</h2>
<!-- raw HTML omitted -->
<h2>What's Changed</h2>
<h3>Changes</h3>
<ul>
<li>feat: working-directory with only-new-issues by <a
href="https://github.com/CfirTsabari"><code>@​CfirTsabari</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/795">golangci/golangci-lint-action#795</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>docs: improve <code>How to use</code> section in README.md by <a
href="https://github.com/tungbq"><code>@​tungbq</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/780">golangci/golangci-lint-action#780</a></li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>build(deps): bump <code>@​types/node</code> from 20.2.5 to 20.3.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/771">golangci/golangci-lint-action#771</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.8 to 5.59.9 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/772">golangci/golangci-lint-action#772</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.8 to 5.59.9 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/773">golangci/golangci-lint-action#773</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.9 to 5.59.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/776">golangci/golangci-lint-action#776</a></li>
<li>build(deps-dev): bump eslint from 8.42.0 to 8.43.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/775">golangci/golangci-lint-action#775</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.3.0 to 20.3.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/777">golangci/golangci-lint-action#777</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.9 to 5.59.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/778">golangci/golangci-lint-action#778</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.11 to 5.60.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/782">golangci/golangci-lint-action#782</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.11 to 5.60.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/783">golangci/golangci-lint-action#783</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.3.1 to 20.3.3 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/784">golangci/golangci-lint-action#784</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.60.0 to 5.60.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/785">golangci/golangci-lint-action#785</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.60.0 to 5.60.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/786">golangci/golangci-lint-action#786</a></li>
<li>build(deps-dev): bump typescript from 5.1.3 to 5.1.6 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/787">golangci/golangci-lint-action#787</a></li>
<li>build(deps-dev): bump eslint from 8.43.0 to 8.44.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/788">golangci/golangci-lint-action#788</a></li>
<li>build(deps): bump tough-cookie and <code>@​azure/ms-rest-js</code>
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://github.com/golangci/golangci-lint-action/pull/790">golangci/golangci-lint-action#790</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.3.3 to 20.4.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/791">golangci/golangci-lint-action#791</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.60.1 to 5.61.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/792">golangci/golangci-lint-action#792</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.60.1 to 5.61.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/793">golangci/golangci-lint-action#793</a></li>
<li>build(deps): bump semver from 6.3.0 to 6.3.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/796">golangci/golangci-lint-action#796</a></li>
<li>build(deps-dev): bump prettier from 2.8.8 to 3.0.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/794">golangci/golangci-lint-action#794</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.4.1 to 20.4.2 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/798">golangci/golangci-lint-action#798</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.61.0 to 5.62.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/799">golangci/golangci-lint-action#799</a></li>
<li>build(deps-dev): bump eslint from 8.44.0 to 8.45.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/801">golangci/golangci-lint-action#801</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.61.0 to 6.0.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/800">golangci/golangci-lint-action#800</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.4.2 to 20.4.4 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/803">golangci/golangci-lint-action#803</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.0.0 to 6.1.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/804">golangci/golangci-lint-action#804</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.0.0 to 6.1.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/805">golangci/golangci-lint-action#805</a></li>
<li>build(deps-dev): bump eslint-plugin-import from 2.27.5 to 2.28.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/808">golangci/golangci-lint-action#808</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.4.4 to 20.4.5 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/809">golangci/golangci-lint-action#809</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.1.0 to 6.2.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/810">golangci/golangci-lint-action#810</a></li>
<li>build(deps-dev): bump eslint-config-prettier from 8.8.0 to 8.9.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/811">golangci/golangci-lint-action#811</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.1.0 to 6.2.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/812">golangci/golangci-lint-action#812</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.4.5 to 20.4.8 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/815">golangci/golangci-lint-action#815</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.2.0 to 6.2.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/816">golangci/golangci-lint-action#816</a></li>
<li>build(deps-dev): bump prettier from 3.0.0 to 3.0.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/817">golangci/golangci-lint-action#817</a></li>
<li>build(deps-dev): bump eslint-config-prettier from 8.9.0 to 9.0.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/818">golangci/golangci-lint-action#818</a></li>
<li>build(deps): bump <code>@​actions/http-client</code> from 2.1.0 to
2.1.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/819">golangci/golangci-lint-action#819</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.2.0 to 6.3.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/821">golangci/golangci-lint-action#821</a></li>
<li>build(deps-dev): bump eslint from 8.45.0 to 8.47.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/823">golangci/golangci-lint-action#823</a></li>
<li>build(deps): bump <code>@​types/node</code> from 20.4.8 to 20.5.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github.com/golangci/golangci-lint-action/pull/824">golangci/golangci-lint-action#824</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.2.1 to 6.3.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/golangci/golangci-lint-action/pull/822">golangci/golangci-lint-action#822</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/3cfe3a4abbb849e10058ce4af15d205b6da42804"><code>3cfe3a4</code></a>
build(deps): bump <code>@​actions/cache</code> from 3.2.3 to 3.2.4 (<a
href="https://github.com/golangci/golangci-lint-action/issues/963">#963</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/cbc59cf0d18a8aa6b4806cab8d5a6ad3622f57fe"><code>cbc59cf</code></a>
build(deps-dev): bump prettier from 3.2.4 to 3.2.5 (<a
href="https://github.com/golangci/golangci-lint-action/issues/960">#960</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/459a04b021b544b77372de9a6e429e0d3c136fac"><code>459a04b</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.19.1 to 6.20.0 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/e2315b67db0fd76598007338449373a42c572b25"><code>e2315b6</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.19.1 to 6.20.0 (<a
href="https://github.com/golangci/golangci-lint-action/issues/961">#961</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/d6173a45d0441c7db097b6014862dde0ddc9b579"><code>d6173a4</code></a>
build(deps): bump <code>@​types/node</code> from 20.11.10 to 20.11.16
(<a
href="https://github.com/golangci/golangci-lint-action/issues/962">#962</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/0e8f5bf773dd8000d6aeb01936f3090976982f33"><code>0e8f5bf</code></a>
build(deps): bump <code>@​types/node</code> from 20.11.5 to 20.11.10 (<a
href="https://github.com/golangci/golangci-lint-action/issues/958">#958</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/349d20632dbaed38f0a492cc991152e3d351e854"><code>349d206</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.19.0 to 6.19.1 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/2221aee28499deb9551e403a0d876df4b0e70067"><code>2221aee</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
6.18.1 to 6.19.1 (<a
href="https://github.com/golangci/golangci-lint-action/issues/954">#954</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/3b44ae5b24a084588d4051d37ccb95e8a709a9a3"><code>3b44ae5</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 6.18.1 to 6.19.0 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/323b871bbc74bdc20959d979cb52c68910b77f37"><code>323b871</code></a>
build(deps-dev): bump prettier from 3.2.2 to 3.2.4 (<a
href="https://github.com/golangci/golangci-lint-action/issues/950">#950</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/golangci/golangci-lint-action/compare/v3...v4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golangci/golangci-lint-action&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rootul Patel <rootulp@gmail.com>

.github/workflows/lint.yml

@@ -20,7 +20,7 @@ jobs:
             .go
             .mod
             .sum
-      - uses: golangci/golangci-lint-action@v3
+      - uses: golangci/golangci-lint-action@v4
         with:
           version: latest
           args: --timeout 10m

README.md

@@ -1,7 +1,7 @@
 # Namespaced Merkle Tree (NMT)
 
 ![Go version](https://img.shields.io/badge/go-1.21-blue.svg)
-[![API Reference](https://camo.githubusercontent.com/915b7be44ada53c290eb157634330494ebe3e30a/68747470733a2f2f676f646f632e6f72672f6769746875622e636f6d2f676f6c616e672f6764646f3f7374617475732e737667)](https://pkg.go.dev/github.com/celestiaorg/nmt)
+[![Go Reference](https://pkg.go.dev/badge/github.com/celestiaorg/nmt.svg)](https://pkg.go.dev/github.com/celestiaorg/nmt)
 ![golangci-lint](https://github.com/celestiaorg/nmt/workflows/golangci-lint/badge.svg?branch=master)
 ![Go](https://github.com/celestiaorg/nmt/workflows/Go/badge.svg)
 ![codecov.io](https://codecov.io/github/celestiaorg/nmt/coverage.svg?branch=master)

fuzz_test.go

@@ -134,7 +134,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
 				c.Fuzz(&lastNs)
 				*s = string(lastNs[:])
 			},
-			func(s *[][]byte, c fuzz.Continue) {
+			func(s *[][]byte, _ fuzz.Continue) {
 				var tmp [][]byte
 				f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
 				f.Fuzz(&tmp)
@@ -152,7 +152,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
 				c.Fuzz(&lastNs)
 				*s = string(lastNs[:])
 			},
-			func(s *[][]byte, c fuzz.Continue) {
+			func(s *[][]byte, _ fuzz.Continue) {
 				var tmp [][]byte
 				f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
 				f.Fuzz(&tmp)
@@ -170,7 +170,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
 				c.Fuzz(&lastNs)
 				*s = string(lastNs[:])
 			},
-			func(s *[][]byte, c fuzz.Continue) {
+			func(s *[][]byte, _ fuzz.Continue) {
 				var tmp [][]byte
 				f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
 				f.Fuzz(&tmp)

nmt.go

@@ -20,7 +20,7 @@ const (
 var (
 	ErrInvalidRange     = errors.New("invalid proof range")
 	ErrInvalidPushOrder = errors.New("pushed data has to be lexicographically ordered by namespace IDs")
-	noOp                = func(hash []byte, children ...[]byte) {}
+	noOp                = func(_ []byte, _ ...[]byte) {}
 )
 
 type NodeVisitorFn = func(hash []byte, children ...[]byte)

nmt_test.go

@@ -530,7 +530,7 @@ func TestNodeVisitor(t *testing.T) {
 		leafSize  = 6
 	)
 	nodeHashes := make([][]byte, 0)
-	collectNodeHashes := func(hash []byte, _children ...[]byte) {
+	collectNodeHashes := func(hash []byte, _ ...[]byte) {
 		nodeHashes = append(nodeHashes, hash)
 	}