Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NebulousLabs' merkletree dependency for proofs as well #15

Closed
liamsi opened this issue Jan 8, 2021 · 0 comments
Closed

Remove NebulousLabs' merkletree dependency for proofs as well #15

liamsi opened this issue Jan 8, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@liamsi
Copy link
Member

liamsi commented Jan 8, 2021

#14 removed the dependency on NebulousLabs' implementation for computing the root of the tree and replaced it a very simple recursive algo that boils down to a few lines of code (derived from the recursive definition of rfc6962 and very similar to the simple merkle tree implementation in tendermint.

It would be nice if the same internal mechanism would be used for generating/verifiying proofs (instead of using the range proofs of nebolousLabs).
@liamsi liamsi mentioned this issue Jan 18, 2021
Merged
@liamsi liamsi added the enhancement New feature or request label Mar 10, 2021
@liamsi liamsi mentioned this issue Mar 20, 2021
Open
@liamsi liamsi moved this to TODO in Celestia Node Dec 5, 2021
@liamsi liamsi mentioned this issue May 5, 2022
Open
@rahulghangas rahulghangas mentioned this issue Sep 5, 2022
Merged
2 tasks
liamsi pushed a commit that referenced this issue Sep 12, 2022
@rahulghangas
Remove dependency on nebulous in verification (#67)
f1abf11 
Use the same recursive approach as in `nmt.Root()` to verify leaf hashes
Removes the dependency on `Celestiaorg/merkletree` in proof verification

Fixes half of the issue mentioned in #15 (Remove NebulousLabs' merkletree dependency for proofs as well)
@rahulghangas rahulghangas mentioned this issue Sep 14, 2022
Merged
2 tasks
@elias-orijtech elias-orijtech mentioned this issue Oct 7, 2022
Closed
Repository owner moved this from TODO to Done in Celestia Node Oct 12, 2022
@renaynay renaynay mentioned this issue Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liamsi