Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestNamespacedMerkleTree_calculateAbsenceIndex_Panic isn’t complete #158

Closed
andrijamitrovic23 opened this issue Mar 24, 2023 · 0 comments · Fixed by #169
Closed

TestNamespacedMerkleTree_calculateAbsenceIndex_Panic isn’t complete #158

andrijamitrovic23 opened this issue Mar 24, 2023 · 0 comments · Fixed by #169
Assignees
Labels
audit Issue uncovered during Informal audit

Comments

@andrijamitrovic23
Copy link
Collaborator

TestNamespacedMerkleTree_calculateAbsenceIndex_Panic obviously isn’t complete. It does not push the data from test cases to the nmt. It passes (the tested function panics as expected) because it tests an empty tree so this panic will be called in both cases. So this test does not test the given cases. Push function should be called for the given data.

One test case should added that tests the panic if the tree is empty, as it is done unintentionally in this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Issue uncovered during Informal audit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants